Re: [dpdk-dev] [PATCH v7 2/2] bus/pci: support MMIO in PCI ioport accessors

2021-03-02 Thread 谢华伟(此时此刻)
On 2021/3/2 21:14, David Marchand wrote: This change is a fix/optimisation. This is a separate topic from adding MMIO support with x86 ioport. I would split as a separate patch. Hi David: Maybe there is confuse? There is no change. The out/in is added. I don't remove _p on purpose. Looking a

Re: [dpdk-dev] [PATCH v7 2/2] bus/pci: support MMIO in PCI ioport accessors

2021-03-02 Thread David Marchand
On Mon, Mar 1, 2021 at 4:44 PM 谢华伟(此时此刻) wrote: > >>> What is the downside of using "pause until the I/O completes" versions? > >> The downside in virtio PMD is a small performance penalty when we use it > >> to notify backend. CPU executes unnecessary serializing IO instruction. > >> > >> I check

Re: [dpdk-dev] [PATCH v7 2/2] bus/pci: support MMIO in PCI ioport accessors

2021-03-01 Thread 谢华伟(此时此刻)
On 2021/2/25 17:52, David Marchand wrote: On Thu, Feb 25, 2021 at 5:00 AM 谢华伟(此时此刻) wrote: Is the 'outb_p' to 'outb' conversion intentional? And if so why? Same of the all 'outb_p', 'outw_p', 'outl_p'. There is no need to delay for virtio device, as we can see in virtio legacy driver. IMO,

Re: [dpdk-dev] [PATCH v7 2/2] bus/pci: support MMIO in PCI ioport accessors

2021-02-25 Thread David Marchand
On Thu, Feb 25, 2021 at 5:00 AM 谢华伟(此时此刻) wrote: > >>> Is the 'outb_p' to 'outb' conversion intentional? And if so why? > >>> > >>> Same of the all 'outb_p', 'outw_p', 'outl_p'. > >> > >> There is no need to delay for virtio device, as we can see in virtio > >> legacy driver. > >> > >> IMO, the de

Re: [dpdk-dev] [PATCH v7 2/2] bus/pci: support MMIO in PCI ioport accessors

2021-02-24 Thread 谢华伟(此时此刻)
On 2021/2/24 23:45, Ferruh Yigit wrote: On 2/23/2021 2:20 PM, 谢华伟(此时此刻) wrote: On 2021/2/23 1:25, Ferruh Yigit wrote: On 2/22/2021 5:15 PM, 谢华伟(此时此刻) wrote: From: "huawei.xhw" With IO BAR, we get PIO(programmed IO) address. With MMIO BAR, we get mapped virtual address. We distinguish PIO(

Re: [dpdk-dev] [PATCH v7 2/2] bus/pci: support MMIO in PCI ioport accessors

2021-02-24 Thread Ferruh Yigit
On 2/23/2021 2:20 PM, 谢华伟(此时此刻) wrote: On 2021/2/23 1:25, Ferruh Yigit wrote: On 2/22/2021 5:15 PM, 谢华伟(此时此刻) wrote: From: "huawei.xhw" With IO BAR, we get PIO(programmed IO) address. With MMIO BAR, we get mapped virtual address. We distinguish PIO(Programmed IO) and MMIO(memory mapped IO) b

Re: [dpdk-dev] [PATCH v7 2/2] bus/pci: support MMIO in PCI ioport accessors

2021-02-23 Thread 谢华伟(此时此刻)
On 2021/2/23 1:25, Ferruh Yigit wrote: On 2/22/2021 5:15 PM, 谢华伟(此时此刻) wrote: From: "huawei.xhw" With IO BAR, we get PIO(programmed IO) address. With MMIO BAR, we get mapped virtual address. We distinguish PIO(Programmed IO) and MMIO(memory mapped IO) by their address like how kernel does.

Re: [dpdk-dev] [PATCH v7 2/2] bus/pci: support MMIO in PCI ioport accessors

2021-02-22 Thread Ferruh Yigit
On 2/22/2021 5:15 PM, 谢华伟(此时此刻) wrote: From: "huawei.xhw" With IO BAR, we get PIO(programmed IO) address. With MMIO BAR, we get mapped virtual address. We distinguish PIO(Programmed IO) and MMIO(memory mapped IO) by their address like how kernel does. ioread/write8/16/32 is provided to access

[dpdk-dev] [PATCH v7 2/2] bus/pci: support MMIO in PCI ioport accessors

2021-02-22 Thread 谢华伟(此时此刻)
From: "huawei.xhw" With IO BAR, we get PIO(programmed IO) address. With MMIO BAR, we get mapped virtual address. We distinguish PIO(Programmed IO) and MMIO(memory mapped IO) by their address like how kernel does. ioread/write8/16/32 is provided to access PIO/MMIO. By the way, for virtio on arch