Re: [dpdk-dev] [PATCH v6 6/8] buildtools/chkincs: add app to verify header includes

2021-01-28 Thread Bruce Richardson
On Thu, Jan 28, 2021 at 12:31:20PM +0100, David Marchand wrote: > On Thu, Jan 28, 2021 at 12:27 PM Bruce Richardson > wrote: > > > > +# some ethdev headers depend on bus headers > > > > +includes = include_directories('../../drivers/bus/pci', > > > > + '../../drivers/bus/vdev') > > > > > > e

Re: [dpdk-dev] [PATCH v6 6/8] buildtools/chkincs: add app to verify header includes

2021-01-28 Thread Bruce Richardson
On Thu, Jan 28, 2021 at 12:31:20PM +0100, David Marchand wrote: > On Thu, Jan 28, 2021 at 12:27 PM Bruce Richardson > wrote: > > > > +# some ethdev headers depend on bus headers > > > > +includes = include_directories('../../drivers/bus/pci', > > > > + '../../drivers/bus/vdev') > > > > > > e

Re: [dpdk-dev] [PATCH v6 6/8] buildtools/chkincs: add app to verify header includes

2021-01-28 Thread David Marchand
On Thu, Jan 28, 2021 at 12:27 PM Bruce Richardson wrote: > > > +# some ethdev headers depend on bus headers > > > +includes = include_directories('../../drivers/bus/pci', > > > + '../../drivers/bus/vdev') > > > > ethdev headers are fine now, afaics. > > So this comment can be changed to a mo

Re: [dpdk-dev] [PATCH v6 6/8] buildtools/chkincs: add app to verify header includes

2021-01-28 Thread Bruce Richardson
On Thu, Jan 28, 2021 at 12:02:35PM +0100, David Marchand wrote: > On Wed, Jan 27, 2021 at 6:37 PM Bruce Richardson > wrote: > > > > To verify that all DPDK headers are ok for inclusion directly in a C file, > > and are not missing any other pre-requisite headers, we can auto-generate > > for each

Re: [dpdk-dev] [PATCH v6 6/8] buildtools/chkincs: add app to verify header includes

2021-01-28 Thread David Marchand
On Wed, Jan 27, 2021 at 6:37 PM Bruce Richardson wrote: > > To verify that all DPDK headers are ok for inclusion directly in a C file, > and are not missing any other pre-requisite headers, we can auto-generate > for each header an empty C file that includes that header. Compiling these > files wi

[dpdk-dev] [PATCH v6 6/8] buildtools/chkincs: add app to verify header includes

2021-01-27 Thread Bruce Richardson
To verify that all DPDK headers are ok for inclusion directly in a C file, and are not missing any other pre-requisite headers, we can auto-generate for each header an empty C file that includes that header. Compiling these files will throw errors if any header has unmet dependencies. To ensure on