Re: [dpdk-dev] [PATCH v6 3/5] telemetry: use unique socket paths for in-memory mode

2021-10-07 Thread Power, Ciara
>-Original Message- >From: Kevin Traynor >Sent: Tuesday 5 October 2021 16:15 >To: Richardson, Bruce >Cc: dev@dpdk.org; Power, Ciara ; David Marchand >; Burakov, Anatoly >Subject: Re: [PATCH v6 3/5] telemetry: use unique socket paths for in-memory >mode > >On 05/10/2021 15:52, Bruce Rich

Re: [dpdk-dev] [PATCH v6 3/5] telemetry: use unique socket paths for in-memory mode

2021-10-05 Thread Conor Walsh
On 05/10/2021 15:52, Bruce Richardson wrote: On Tue, Oct 05, 2021 at 03:41:17PM +0100, Kevin Traynor wrote: Hi Bruce, I started reviewing v5 before v6 was pushed, so these are just comments from v5, No problem. Changes V6-v5 are fairly small anyway. Thanks for the review. On 05/10/2021 14:

Re: [dpdk-dev] [PATCH v6 3/5] telemetry: use unique socket paths for in-memory mode

2021-10-05 Thread Kevin Traynor
On 05/10/2021 15:52, Bruce Richardson wrote: On Tue, Oct 05, 2021 at 03:41:17PM +0100, Kevin Traynor wrote: Hi Bruce, I started reviewing v5 before v6 was pushed, so these are just comments from v5, No problem. Changes V6-v5 are fairly small anyway. Thanks for the review. On 05/10/2021 14:5

Re: [dpdk-dev] [PATCH v6 3/5] telemetry: use unique socket paths for in-memory mode

2021-10-05 Thread Bruce Richardson
On Tue, Oct 05, 2021 at 03:41:17PM +0100, Kevin Traynor wrote: > Hi Bruce, I started reviewing v5 before v6 was pushed, so these are just > comments from v5, > No problem. Changes V6-v5 are fairly small anyway. Thanks for the review. > On 05/10/2021 14:59, Bruce Richardson wrote: > > When DPDK i

Re: [dpdk-dev] [PATCH v6 3/5] telemetry: use unique socket paths for in-memory mode

2021-10-05 Thread Kevin Traynor
Hi Bruce, I started reviewing v5 before v6 was pushed, so these are just comments from v5, On 05/10/2021 14:59, Bruce Richardson wrote: When DPDK is run using "in-memory" flag, multiple processes can be run using the same file-prefix and hence the same runtime directory. To avoid problems with

[dpdk-dev] [PATCH v6 3/5] telemetry: use unique socket paths for in-memory mode

2021-10-05 Thread Bruce Richardson
When DPDK is run using "in-memory" flag, multiple processes can be run using the same file-prefix and hence the same runtime directory. To avoid problems with conflicting telemetry unix socket paths, we can put the pid of the process into the socket name. As with the existing telemetry socket files