d RX burst, host receives
>> >> >> frag[0]
>> >> >>
>> >> >> and also call rte_gro_reassemble(), and timestamp of frag[0] is
>> >> >> 11; the
>> >> >>
>> >> >> third time, host receives f
e
> >> >>
> >> >> fragments are stored in three items of a UDP GRO table:
> >> >>
> >> >> items[0]: frag[0], timestamp is 11
> >> >>
> >> >> items[1]: frag[1], timestamp is 10
> >> >
of frag[2] is 12. The
>> >> three
>> >>
>> >> fragments are stored in three items of a UDP GRO table:
>> >>
>> >> items[0]: frag[0], timestamp is 11
>> >>
>> >> items[1]: frag[1], timestamp is 10
>> &g
], timestamp is 11
> >>
> >> items[1]: frag[1], timestamp is 10
> >>
> >> items[2]: frag[2], timestamp is 12
> >>
> >> Now we want to flush packets whose timestamp is less than or equal to
> >>
> >> 10. frag[1] should b
ts will be
>> flushed.
>>
>> Because the timestamp of items[0] is greater than 10, the left two
>> fragments
>>
>> will not be checked. This is what I want to say.
>>
>>
>>
>> From: yang_y_yi
>&g
o say.
>
>
>
> From: yang_y_yi
> Sent: Tuesday, September 22, 2020 9:44 AM
> To: Hu, Jiayu
> Cc: dev@dpdk.org; tho...@monjalon.net; yangy...@inspur.com
> Subject: Re:Re: [dpdk-dev] [PATCH v6 2/3] gro: add VXLAN UDP/IPv4 GRO
> support
> Impor
ts
will not be checked. This is what I want to say.
From: yang_y_yi
Sent: Tuesday, September 22, 2020 9:44 AM
To: Hu, Jiayu
Cc: dev@dpdk.org; tho...@monjalon.net; yangy...@inspur.com
Subject: Re:Re: [dpdk-dev] [PATCH v6 2/3] gro: add VXLAN UDP/IPv4 GRO support
Importance: High
BTW, start_
.
Because the timestamp of items[0] is greater than 10, the left two fragments
will not be checked. This is what I want to say.
From: yang_y_yi
Sent: Tuesday, September 22, 2020 9:44 AM
To: Hu, Jiayu
Cc: dev@dpdk.org; tho...@monjalon.net; yangy...@inspur.com
Subject: Re:Re: [dpdk-dev] [PATCH v6 2/3] gro
Jiayu, you didn't get my point. I just show what you want by code, but that
isn't a good way. I think current code is most reasonable. Please check my
comments in last email, actually, only the first packet of a flow is checked by
timestamp, if this flow includes some new items (you're saying),
On Tue, Sep 22, 2020 at 09:29:38AM +0800, yang_y_yi wrote:
> Thanks Jiayu, I have fixed other comments except this one:
>
>
> >The items of a flow are ordered by frag_oft, and start_time
> >of these items is not always in ascending order. Therefore,
> >you cannot skip checking the items after the
BTW, start_time is checked for the first packet in a flow,
gro_udp4_merge_items(tbl, j) will merge all the packets in this flow once if
they can be reassembled, gro_udp4_merge_items(tbl, j) doesn't check start_time,
so this still can let some new items in this flow have chance to be merged.
At
Thanks Jiayu, I have fixed other comments except this one:
>The items of a flow are ordered by frag_oft, and start_time
>of these items is not always in ascending order. Therefore,
>you cannot skip checking the items after the item whose
>start_time is greater than flush_timestamp. This issue al
Hi Yi,
Some comments are inline.
Thanks,
Jiayu
> -Original Message-
> From: yang_y...@163.com
> Sent: Thursday, September 17, 2020 11:50 AM
> To: dev@dpdk.org
> Cc: Hu, Jiayu ; tho...@monjalon.net;
> yangy...@inspur.com; yang_y...@163.com
> Subject: [PATCH v6 2/3] gro: add VXLAN UDP/IPv
From: Yi Yang
VXLAN UDP/IPv4 GRO can help improve VM-to-VM UDP
performance when UFO or GSO is enabled in VM, GRO
must be supported if UFO or GSO is enabled,
otherwise, performance can't get big improvement
if only GSO is there.
With this enabled in DPDK, OVS DPDK can leverage it
to improve VM-to
14 matches
Mail list logo
