Re: [dpdk-dev] [PATCH v6 2/2] power: refactor pstate and acpi code

2021-07-08 Thread David Hunt
On 8/7/2021 1:49 PM, David Marchand wrote: On Wed, Jun 23, 2021 at 2:04 PM David Hunt wrote: From: Anatoly Burakov Currently, ACPI and PSTATE modes have lots of code duplication, confusing logic, and a bunch of other issues that can, and have, led to various bugs and resource leaks. This c

Re: [dpdk-dev] [PATCH v6 2/2] power: refactor pstate and acpi code

2021-07-08 Thread David Marchand
On Wed, Jun 23, 2021 at 2:04 PM David Hunt wrote: > > From: Anatoly Burakov > > Currently, ACPI and PSTATE modes have lots of code duplication, > confusing logic, and a bunch of other issues that can, and have, led to > various bugs and resource leaks. > > This commit factors out the common parts

Re: [dpdk-dev] [PATCH v6 2/2] power: refactor pstate and acpi code

2021-06-29 Thread Richael Zhuang
Hi, It looks good to me. I verified on arm platforms and didn't find any problem currently. BR, Richael > -Original Message- > From: David Hunt > Sent: Wednesday, June 23, 2021 8:04 PM > To: dev@dpdk.org > Cc: david.h...@intel.com; anatoly.bura...@intel.com; Richael Zhuang > ; step...@n

Re: [dpdk-dev] [PATCH v6 2/2] power: refactor pstate and acpi code

2021-06-23 Thread Burakov, Anatoly
On 23-Jun-21 1:03 PM, David Hunt wrote: From: Anatoly Burakov Currently, ACPI and PSTATE modes have lots of code duplication, confusing logic, and a bunch of other issues that can, and have, led to various bugs and resource leaks. This commit factors out the common parts of sysfs reading/writi

[dpdk-dev] [PATCH v6 2/2] power: refactor pstate and acpi code

2021-06-23 Thread David Hunt
From: Anatoly Burakov Currently, ACPI and PSTATE modes have lots of code duplication, confusing logic, and a bunch of other issues that can, and have, led to various bugs and resource leaks. This commit factors out the common parts of sysfs reading/writing for ACPI and PSTATE drivers. Signed-of