Re: [dpdk-dev] [PATCH v6 2/2] app/testpmd: fix port stop

2017-03-10 Thread Iremonger, Bernard
> -Original Message- > From: Wu, Jingjing > Sent: Friday, March 10, 2017 4:56 PM > To: Thomas Monjalon ; Iremonger, Bernard > > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v6 2/2] app/testpmd: fix port stop > > > > To change minor, we can stop p

Re: [dpdk-dev] [PATCH v6 2/2] app/testpmd: fix port stop

2017-03-10 Thread Wu, Jingjing
> > To change minor, we can stop port, then configure VMDQ and then start port. > > > > You make port started in VMDQ config, the Symmetry of stop/start command > is broken and it is not easy to maintain. > > Should we close this patch in patchwork? Yes, I think so. Thanks Jingjing

Re: [dpdk-dev] [PATCH v6 2/2] app/testpmd: fix port stop

2017-03-10 Thread Thomas Monjalon
2017-02-12 04:34, Wu, Jingjing: > > > > --- a/app/test-pmd/testpmd.c > > > > +++ b/app/test-pmd/testpmd.c > > > > @@ -1490,13 +1490,13 @@ stop_port(portid_t pid) > > > > continue; > > > > } > > > > > > > > + rte_eth_dev_stop(pi); > > > > + > > >

Re: [dpdk-dev] [PATCH v6 2/2] app/testpmd: fix port stop

2017-02-11 Thread Wu, Jingjing
> -Original Message- > From: Iremonger, Bernard > Sent: Friday, February 3, 2017 6:38 PM > To: Wu, Jingjing ; dev@dpdk.org > Cc: sta...@dpdk.org > Subject: RE: [PATCH v6 2/2] app/testpmd: fix port stop > > Hi Jingjing > > > -Original Message- > > From: Wu, Jingjing > > Sent: Fri

Re: [dpdk-dev] [PATCH v6 2/2] app/testpmd: fix port stop

2017-02-03 Thread Iremonger, Bernard
Hi Jingjing > -Original Message- > From: Wu, Jingjing > Sent: Friday, February 3, 2017 8:22 AM > To: Iremonger, Bernard ; dev@dpdk.org > Cc: sta...@dpdk.org > Subject: RE: [PATCH v6 2/2] app/testpmd: fix port stop > > > > > -Original Message- > > From: Iremonger, Bernard > > Sen

Re: [dpdk-dev] [PATCH v6 2/2] app/testpmd: fix port stop

2017-02-03 Thread Wu, Jingjing
> -Original Message- > From: Iremonger, Bernard > Sent: Friday, January 27, 2017 6:50 PM > To: dev@dpdk.org; Wu, Jingjing > Cc: Iremonger, Bernard ; sta...@dpdk.org > Subject: [PATCH v6 2/2] app/testpmd: fix port stop > > The rte_eth_dev_stop function is not called if the port_status is

[dpdk-dev] [PATCH v6 2/2] app/testpmd: fix port stop

2017-01-27 Thread Bernard Iremonger
The rte_eth_dev_stop function is not called if the port_status is not RTE_PORT_STARTED. This can happen if the rte_eth_dev_start function is called directly, ie not through the start_port function. Make sure rte_eth_dev_stop is always called in stop_port function. Fixes: ce8d561418d4 ("app/testpm