Re: [dpdk-dev] [PATCH v6 1/2] ethdev: add pre-defined meter policy API

2021-04-14 Thread Li Zhang
Thanks Jasvinder. Will change it in V7 patch. Regards, Li Zhang > -Original Message- > From: Singh, Jasvinder > Sent: Thursday, April 15, 2021 6:22 AM > To: Li Zhang ; dek...@nvidia.com; Ori Kam > ; Slava Ovsiienko ; Matan > Azrad ; Shahaf Shuler ; > Dumitrescu, Cristian ; lir...@marvell

Re: [dpdk-dev] [PATCH v6 1/2] ethdev: add pre-defined meter policy API

2021-04-14 Thread Li Zhang
Thanks Cristian. Will change it in V7 patch. Regards, Li Zhang > -Original Message- > From: Dumitrescu, Cristian > Sent: Thursday, April 15, 2021 12:16 AM > To: Li Zhang ; dek...@nvidia.com; Ori Kam > ; Slava Ovsiienko ; Matan > Azrad ; Shahaf Shuler ; > lir...@marvell.com; jer...@marvel

Re: [dpdk-dev] [PATCH v6 1/2] ethdev: add pre-defined meter policy API

2021-04-14 Thread Singh, Jasvinder
> +/* MTR meter policy add */ > +static int > +pmd_mtr_meter_policy_add(struct rte_eth_dev *dev, > + uint32_t meter_policy_id, > + struct rte_mtr_meter_policy_params *policy, > + struct rte_mtr_error *error) > +{ > + struct pmd_internals *p = dev->data->dev_private; > + struc

Re: [dpdk-dev] [PATCH v6 1/2] ethdev: add pre-defined meter policy API

2021-04-14 Thread Dumitrescu, Cristian
Hi Li, Following the API changes, there are lots of changes in the drivers, as expected, so we'll have to take the necessary time to review them. Here are just a few comments below, please expect more during the next few days. > + > +/* MTR meter policy add */ > +static int > +pmd_mtr_meter_p

[dpdk-dev] [PATCH v6 1/2] ethdev: add pre-defined meter policy API

2021-04-14 Thread Li Zhang
Currently, the flow meter policy does not support multiple actions per color; also the allowed action types per color are very limited. In addition, the policy cannot be pre-defined. Due to the growing in flow actions offload abilities there is a potential for the user to use variety of actions pe