Re: [dpdk-dev] [PATCH v6 1/2] ethdev: add packet integrity checks

2021-04-18 Thread Thomas Monjalon
Please read again the comment I did below, and try 32-bit bitfield instead of 64-bit. 18/04/2021 21:24, Gregory Etelson: > Hello Thomas, > > I modified the following drivers/net/mlx5/mlx5_flow_age.c compilation command > to produce pre-processed source code output: > > 1 # 1 "../drivers/ne

Re: [dpdk-dev] [PATCH v6 1/2] ethdev: add packet integrity checks

2021-04-18 Thread Gregory Etelson
Hello Thomas, I modified the following drivers/net/mlx5/mlx5_flow_age.c compilation command to produce pre-processed source code output: 1 # 1 "../drivers/net/mlx5/mlx5_flow_age.c" 2 # 1 "/.autodirect/mtrswgwork/getelson/src/dpdk/stable/build-dev//" 3 # 1 "" 4 #define __STDC__

Re: [dpdk-dev] [PATCH v6 1/2] ethdev: add packet integrity checks

2021-04-18 Thread Thomas Monjalon
18/04/2021 17:51, Gregory Etelson: > +__extension__ That still doesn't make sense, as in v5. The things which require a macro are anonymous union, anonymous struct and some bit fields with special sizes. > +struct rte_flow_item_integrity { > + /**< Tunnel encapsulation level the item should a

[dpdk-dev] [PATCH v6 1/2] ethdev: add packet integrity checks

2021-04-18 Thread Gregory Etelson
From: Ori Kam Currently, DPDK application can offload the checksum check, and report it in the mbuf. However, as more and more applications are offloading some or all logic and action to the HW, there is a need to check the packet integrity so the right decision can be taken. The application lo