Re: [dpdk-dev] [PATCH v6 1/2] eal: add uevent monitor for hot plug

2018-01-02 Thread Guo, Jia
On 12/26/2017 2:06 AM, Stephen Hemminger wrote: On Thu, 2 Nov 2017 04:16:44 +0800 Jeff Guo wrote: +int +rte_dev_bind_driver(const char *dev_name, const char *drv_type) { Bracket left after declaration. thanks. + snprintf(drv_override_path, sizeof(drv_override_path), +

Re: [dpdk-dev] [PATCH v6 1/2] eal: add uevent monitor for hot plug

2017-12-25 Thread Stephen Hemminger
On Thu, 2 Nov 2017 04:16:44 +0800 Jeff Guo wrote: > +int > +rte_dev_bind_driver(const char *dev_name, const char *drv_type) { Bracket left after declaration. > + snprintf(drv_override_path, sizeof(drv_override_path), > + "/sys/bus/pci/devices/%s/driver_override", dev_name); >

Re: [dpdk-dev] [PATCH v6 1/2] eal: add uevent monitor for hot plug

2017-12-25 Thread Guo, Jia
On 11/2/2017 5:41 AM, Stephen Hemminger wrote: On Thu, 2 Nov 2017 04:16:44 +0800 Jeff Guo wrote: + +static int +dev_uev_parse(const char *buf, struct rte_eal_uevent *event) +{ + char action[RTE_EAL_UEVENT_MSG_LEN]; + char subsystem[RTE_EAL_UEVENT_MSG_LEN]; + char dev_path[

[dpdk-dev] [PATCH v6 1/2] eal: add uevent monitor for hot plug

2017-12-13 Thread Mordechay Haimovsky
Hello Jeff, I've failed to apply the patch on latest DPDK (git://dpdk.org/dpdk), Due to missing eal_common_vdev.c file What am I doing wrong ? Moti $ patch -p1 < dpdk-dev-v6-1-2-eal-add-uevent-monitor-for-hot-plug.patch patching file drivers/bus/pci/bsd/pci.c Hunk

Re: [dpdk-dev] [PATCH v6 1/2] eal: add uevent monitor for hot plug

2017-11-07 Thread Guo, Jia
Thanks Stephen for your eye on review, would collect other comment and refine it better in next version. Best regards, Jeff Guo -Original Message- From: Stephen Hemminger [mailto:step...@networkplumber.org] Sent: Thursday, November 2, 2017 5:42 AM To: Guo, Jia Cc: Richardson, Bruce ; Y

Re: [dpdk-dev] [PATCH v6 1/2] eal: add uevent monitor for hot plug

2017-11-01 Thread Stephen Hemminger
On Thu, 2 Nov 2017 04:16:44 +0800 Jeff Guo wrote: > + > +static int > +dev_uev_parse(const char *buf, struct rte_eal_uevent *event) > +{ > + char action[RTE_EAL_UEVENT_MSG_LEN]; > + char subsystem[RTE_EAL_UEVENT_MSG_LEN]; > + char dev_path[RTE_EAL_UEVENT_MSG_LEN]; > + char pci_sl

Re: [dpdk-dev] [PATCH v6 1/2] eal: add uevent monitor for hot plug

2017-11-01 Thread Stephen Hemminger
On Thu, 2 Nov 2017 04:16:44 +0800 Jeff Guo wrote: > > +/* Map pci device */ > +int > +rte_pci_remap_device(struct rte_pci_device *dev) > +{ > + int ret = -1; Please don't always initialize variables. It is unnecessary, and with modern compilers a bad habit since it defeats the uninitailiz

[dpdk-dev] [PATCH v6 1/2] eal: add uevent monitor for hot plug

2017-10-31 Thread Jeff Guo
This patch aim to add a general uevent mechanism in eal device layer, to enable all linux kernel object hot plug monitoring, so user could use these APIs to monitor and read out the device status info that sent from the kernel side, then corresponding to handle it, such as detach or attach the devi