Re: [dpdk-dev] [PATCH v6 03/10] eal: include filesystem implementation for windows

2020-01-31 Thread Pallavi Kadam
Hi Dmitry, Thank you for reviewing the code and for your comments. On 1/30/2020 10:04 PM, Dmitry Kozliuk wrote: Hello Pallavi, +#include "eal_internal_cfg.h" + +/* sets up platform-specific runtime data dir */ +int +eal_create_runtime_dir(void); + +/* returns runtime dir */ +const char * +eal

Re: [dpdk-dev] [PATCH v6 03/10] eal: include filesystem implementation for windows

2020-01-30 Thread Dmitry Kozliuk
Hello Pallavi, > +#include "eal_internal_cfg.h" > + > +/* sets up platform-specific runtime data dir */ > +int > +eal_create_runtime_dir(void); > + > +/* returns runtime dir */ > +const char * > +eal_get_runtime_dir(void); Any reason not to #include "eal_filesystem.h"? > + > +static inline const

[dpdk-dev] [PATCH v6 03/10] eal: include filesystem implementation for windows

2020-01-30 Thread Pallavi Kadam
Adding eal_filesystem.h to support functions and path defines for files and directories on Windows. Signed-off-by: Antara Ganesh Kolar Signed-off-by: Pallavi Kadam Reviewed-by: Ranjit Menon Reviewed-by: Keith Wiles --- .../windows/eal/include/eal_filesystem.h | 94 +++ 1