Re: [dpdk-dev] [PATCH v6] vhost: support virtqueue interrupt/notification suppression

2018-01-08 Thread Yuanhan Liu
On Tue, Jan 09, 2018 at 02:12:02AM +, Chen, Junjie J wrote: > > > + if (vring_need_event(vhost_used_event(vq), new, old) > > > > It's a bit weird that you use one from the standard linux header file > > (vring_need_event), while you define you own one (vhost_used_event). > > Note that

Re: [dpdk-dev] [PATCH v6] vhost: support virtqueue interrupt/notification suppression

2018-01-08 Thread Chen, Junjie J
Hi > -Original Message- > From: Yuanhan Liu [mailto:y...@fridaylinux.org] > Sent: Monday, January 8, 2018 10:07 PM > To: Chen, Junjie J > Cc: Wang, Xiao W ; maxime.coque...@redhat.com; > Bie, Tiwei ; dev@dpdk.org; Yao, Lei A > > Subject: Re: [PATCH v6] vhost: support virtqueue interrupt/

Re: [dpdk-dev] [PATCH v6] vhost: support virtqueue interrupt/notification suppression

2018-01-08 Thread Yuanhan Liu
On Tue, Dec 26, 2017 at 12:43:10PM -0500, Junjie Chen wrote: > The driver can suppress interrupt when VIRTIO_F_EVENT_IDX feature bit is > negotiated. The driver set vring flags to 0, and MAY use used_event in > available ring to advise device interrupt util reach an index specified > by used_event.

Re: [dpdk-dev] [PATCH v6] vhost: support virtqueue interrupt/notification suppression

2018-01-04 Thread Wang, Xiao W
Hi, > -Original Message- > From: Chen, Junjie J > Sent: Wednesday, December 27, 2017 1:43 AM > To: Wang, Xiao W ; y...@fridaylinux.org; > maxime.coque...@redhat.com; Bie, Tiwei > Cc: dev@dpdk.org; Chen, Junjie J > Subject: [PATCH v6] vhost: support virtqueue interrupt/notification > supp

[dpdk-dev] [PATCH v6] vhost: support virtqueue interrupt/notification suppression

2017-12-26 Thread Junjie Chen
The driver can suppress interrupt when VIRTIO_F_EVENT_IDX feature bit is negotiated. The driver set vring flags to 0, and MAY use used_event in available ring to advise device interrupt util reach an index specified by used_event. The device ignore the lower bit of vring flags, and send an interrup