Re: [dpdk-dev] [PATCH v6] ethdev: add sanity checks in control APIs

2021-04-18 Thread Min Hu (Connor)
在 2021/4/18 5:37, Thomas Monjalon 写道: 17/04/2021 02:28, Min Hu (Connor): 在 2021/4/17 0:28, Stephen Hemminger 写道: On Fri, 16 Apr 2021 11:22:02 +0100 Kevin Traynor wrote: + if (dev_conf == NULL) { + RTE_ETHDEV_LOG(ERR, + "Cannot configure ethdev po

Re: [dpdk-dev] [PATCH v6] ethdev: add sanity checks in control APIs

2021-04-17 Thread Thomas Monjalon
17/04/2021 02:28, Min Hu (Connor): > > 在 2021/4/17 0:28, Stephen Hemminger 写道: > > On Fri, 16 Apr 2021 11:22:02 +0100 > > Kevin Traynor wrote: > > > >>> + if (dev_conf == NULL) { > >>> + RTE_ETHDEV_LOG(ERR, > >>> + "Cannot configure ethdev port %u to NULL dev_conf\n", > >

Re: [dpdk-dev] [PATCH v6] ethdev: add sanity checks in control APIs

2021-04-17 Thread Min Hu (Connor)
在 2021/4/17 0:28, Stephen Hemminger 写道: On Fri, 16 Apr 2021 11:22:02 +0100 Kevin Traynor wrote: + if (dev_conf == NULL) { + RTE_ETHDEV_LOG(ERR, + "Cannot configure ethdev port %u to NULL dev_conf\n", The others use a natural sounding names instead

Re: [dpdk-dev] [PATCH v6] ethdev: add sanity checks in control APIs

2021-04-16 Thread Min Hu (Connor)
在 2021/4/17 0:28, Stephen Hemminger 写道: On Fri, 16 Apr 2021 11:22:02 +0100 Kevin Traynor wrote: + if (dev_conf == NULL) { + RTE_ETHDEV_LOG(ERR, + "Cannot configure ethdev port %u to NULL dev_conf\n", The others use a natural sounding names instead

Re: [dpdk-dev] [PATCH v6] ethdev: add sanity checks in control APIs

2021-04-16 Thread Stephen Hemminger
On Fri, 16 Apr 2021 11:22:02 +0100 Kevin Traynor wrote: > > + if (dev_conf == NULL) { > > + RTE_ETHDEV_LOG(ERR, > > + "Cannot configure ethdev port %u to NULL dev_conf\n", > > The others use a natural sounding names instead of argument name. If you > wanted to mat

Re: [dpdk-dev] [PATCH v6] ethdev: add sanity checks in control APIs

2021-04-16 Thread Min Hu (Connor)
Hi, Kevin and all fixed in v7, thanks. 在 2021/4/16 18:22, Kevin Traynor 写道: On 16/04/2021 07:52, Min Hu (Connor) wrote: This patch adds more sanity checks in control path APIs. Fixes: 214ed1acd125 ("ethdev: add iterator to match devargs input") Fixes: 3d98f921fbe9 ("ethdev: unify prefi

Re: [dpdk-dev] [PATCH v6] ethdev: add sanity checks in control APIs

2021-04-16 Thread Kevin Traynor
On 16/04/2021 07:52, Min Hu (Connor) wrote: > This patch adds more sanity checks in control path APIs. > > Fixes: 214ed1acd125 ("ethdev: add iterator to match devargs input") > Fixes: 3d98f921fbe9 ("ethdev: unify prefix for static functions and > variables") > Fixes: 0366137722a0 ("ethdev: check

[dpdk-dev] [PATCH v6] ethdev: add sanity checks in control APIs

2021-04-15 Thread Min Hu (Connor)
This patch adds more sanity checks in control path APIs. Fixes: 214ed1acd125 ("ethdev: add iterator to match devargs input") Fixes: 3d98f921fbe9 ("ethdev: unify prefix for static functions and variables") Fixes: 0366137722a0 ("ethdev: check for invalid device name") Fixes: d948f596fee2 ("ethdev: f