[dpdk-dev] [PATCH v5 resend 07/12] virtio: resolve for control queue

2015-10-13 Thread Yuanhan Liu
On Mon, Oct 12, 2015 at 10:58:17PM +0200, Steffen Bauch wrote: > On 10/12/2015 10:39 AM, Yuanhan Liu wrote: > >Hi, > > > >I just recognized that this dead loop is the same one that I have > >experienced (see > >http://dpdk.org/ml/archives/dev/2015-October/024737.html for > >reference). Just applyin

[dpdk-dev] [PATCH v5 resend 07/12] virtio: resolve for control queue

2015-10-12 Thread Steffen Bauch
On 10/12/2015 10:39 AM, Yuanhan Liu wrote: > Hi, > > I just recognized that this dead loop is the same one that I have > experienced (see > http://dpdk.org/ml/archives/dev/2015-October/024737.html for > reference). Just applying the changes in this patch (only 07/12) > will not fix the dead loop at

[dpdk-dev] [PATCH v5 resend 07/12] virtio: resolve for control queue

2015-10-12 Thread Yuanhan Liu
On Thu, Oct 08, 2015 at 10:51:02PM +0200, Steffen Bauch wrote: > > > On 10/08/2015 05:32 PM, Nikita Kalyazin wrote: > >Hi Yuanhan, > > > > > >As I understand, the dead loop happened here (virtio_send_command): > >while (vq->vq_used_cons_idx == vq->vq_ring.used->idx) { > > rte_rmb(); > >

[dpdk-dev] [PATCH v5 resend 07/12] virtio: resolve for control queue

2015-10-12 Thread Xie, Huawei
On 10/12/2015 10:33 AM, Xie, Huawei wrote: > On 10/12/2015 9:39 AM, Yuanhan Liu wrote: >> On Thu, Oct 08, 2015 at 10:51:02PM +0200, Steffen Bauch wrote: >>> On 10/08/2015 05:32 PM, Nikita Kalyazin wrote: Hi Yuanhan, As I understand, the dead loop happened here (virtio_send_comma

[dpdk-dev] [PATCH v5 resend 07/12] virtio: resolve for control queue

2015-10-12 Thread Xie, Huawei
On 10/12/2015 9:39 AM, Yuanhan Liu wrote: > On Thu, Oct 08, 2015 at 10:51:02PM +0200, Steffen Bauch wrote: >> >> On 10/08/2015 05:32 PM, Nikita Kalyazin wrote: >>> Hi Yuanhan, >>> >>> >>> As I understand, the dead loop happened here (virtio_send_command): >>> while (vq->vq_used_cons_idx == vq->vq_r

[dpdk-dev] [PATCH v5 resend 07/12] virtio: resolve for control queue

2015-10-09 Thread Nikita Kalyazin
Hi, > I just recognized that this dead loop is the same one that I have > experienced (see > http://dpdk.org/ml/archives/dev/2015-October/024737.html for reference). > Just applying the changes in this patch (only 07/12) will not fix the > dead loop at least in my setup. Yes, exactly. I observ

[dpdk-dev] [PATCH v5 resend 07/12] virtio: resolve for control queue

2015-10-08 Thread Steffen Bauch
On 10/08/2015 05:32 PM, Nikita Kalyazin wrote: > Hi Yuanhan, > > > As I understand, the dead loop happened here (virtio_send_command): > while (vq->vq_used_cons_idx == vq->vq_ring.used->idx) { >rte_rmb(); >usleep(100); > } > > Could you explain why wrong config reading caused that

[dpdk-dev] [PATCH v5 resend 07/12] virtio: resolve for control queue

2015-10-08 Thread Nikita Kalyazin
Hi Yuanhan, As I understand, the dead loop happened here (virtio_send_command): while (vq->vq_used_cons_idx == vq->vq_ring.used->idx) { rte_rmb(); usleep(100); } Could you explain why wrong config reading caused that and how correct reading helps to avoid? -- Best regards, Nikit

[dpdk-dev] [PATCH v5 resend 07/12] virtio: resolve for control queue

2015-09-21 Thread Yuanhan Liu
On Sun, Sep 20, 2015 at 12:21:14PM +0300, Michael S. Tsirkin wrote: > On Fri, Sep 18, 2015 at 11:10:56PM +0800, Yuanhan Liu wrote: > > From: Changchun Ouyang > > > > Fix the max virtio queue pair read issue. > > > > Control queue can't work for vhost-user mulitple queue mode, > > so introduce a

[dpdk-dev] [PATCH v5 resend 07/12] virtio: resolve for control queue

2015-09-20 Thread Michael S. Tsirkin
On Fri, Sep 18, 2015 at 11:10:56PM +0800, Yuanhan Liu wrote: > From: Changchun Ouyang > > Fix the max virtio queue pair read issue. > > Control queue can't work for vhost-user mulitple queue mode, > so introduce a counter to void the dead loop when polling > the control queue. > > Signed-off-by

[dpdk-dev] [PATCH v5 resend 07/12] virtio: resolve for control queue

2015-09-18 Thread Yuanhan Liu
From: Changchun Ouyang Fix the max virtio queue pair read issue. Control queue can't work for vhost-user mulitple queue mode, so introduce a counter to void the dead loop when polling the control queue. Signed-off-by: Changchun Ouyang Signed-off-by: Yuanhan Liu --- drivers/net/virtio/virtio_