Hi Thomas,
On 27/10/2021 10:29, Thomas Monjalon wrote:
26/10/2021 22:29, Medvedkin, Vladimir:
Hi Thomas,
Thanks for the review, I'll address your comments in v6.
Please find my comment below
On 25/10/2021 19:02, Thomas Monjalon wrote:
21/10/2021 20:54, Vladimir Medvedkin:
This patch adds pe
26/10/2021 22:29, Medvedkin, Vladimir:
> Hi Thomas,
>
> Thanks for the review, I'll address your comments in v6.
> Please find my comment below
>
> On 25/10/2021 19:02, Thomas Monjalon wrote:
> > 21/10/2021 20:54, Vladimir Medvedkin:
> >> This patch adds performance tests for different implementa
Hi Stephen,
On 25/10/2021 19:27, Stephen Hemminger wrote:
On Thu, 21 Oct 2021 19:54:29 +0100
Vladimir Medvedkin wrote:
+static uint8_t default_rss_key[] = {
Should this be const?
That way you can make sure API isn't modifying it.
Thanks, I'll fix this in v6
--
Regards,
Vladimir
Hi Thomas,
Thanks for the review, I'll address your comments in v6.
Please find my comment below
On 25/10/2021 19:02, Thomas Monjalon wrote:
21/10/2021 20:54, Vladimir Medvedkin:
This patch adds performance tests for different implementations
of the Toeplitz hash function.
Please name them.
On Thu, 21 Oct 2021 19:54:29 +0100
Vladimir Medvedkin wrote:
> +static uint8_t default_rss_key[] = {
Should this be const?
That way you can make sure API isn't modifying it.
21/10/2021 20:54, Vladimir Medvedkin:
> This patch adds performance tests for different implementations
> of the Toeplitz hash function.
Please name them.
> Signed-off-by: Vladimir Medvedkin
There are some garbage,
> @@ -320,6 +321,7 @@ perf_test_names = [
> 'hash_readwrite_lf_perf_au
This patch adds performance tests for different implementations
of the Toeplitz hash function.
Signed-off-by: Vladimir Medvedkin
---
app/test/meson.build | 2 +
app/test/test_thash_perf.c | 120 +
2 files changed, 122 insertions(+)
create mode
7 matches
Mail list logo
