Re: [dpdk-dev] [PATCH v5 4/8] net/ether: use bitops to speedup comparison

2019-07-02 Thread Stephen Hemminger
On Tue, 2 Jul 2019 11:26:15 +0200 Olivier Matz wrote: > On Tue, Jul 02, 2019 at 09:53:14AM +0200, Olivier Matz wrote: > > Hi, > > > > On Mon, Jun 24, 2019 at 01:44:31PM -0700, Stephen Hemminger wrote: > > > Using bit operations like or and xor is faster than a loop > > > on all architectures.

Re: [dpdk-dev] [PATCH v5 4/8] net/ether: use bitops to speedup comparison

2019-07-02 Thread Olivier Matz
On Tue, Jul 02, 2019 at 09:53:14AM +0200, Olivier Matz wrote: > Hi, > > On Mon, Jun 24, 2019 at 01:44:31PM -0700, Stephen Hemminger wrote: > > Using bit operations like or and xor is faster than a loop > > on all architectures. Really just explicit unrolling. > > > > Similar cast to uint16 unalig

Re: [dpdk-dev] [PATCH v5 4/8] net/ether: use bitops to speedup comparison

2019-07-02 Thread Olivier Matz
Hi, On Mon, Jun 24, 2019 at 01:44:31PM -0700, Stephen Hemminger wrote: > Using bit operations like or and xor is faster than a loop > on all architectures. Really just explicit unrolling. > > Similar cast to uint16 unaligned is already done in > other functions here. > > Signed-off-by: Stephen H

[dpdk-dev] [PATCH v5 4/8] net/ether: use bitops to speedup comparison

2019-06-24 Thread Stephen Hemminger
Using bit operations like or and xor is faster than a loop on all architectures. Really just explicit unrolling. Similar cast to uint16 unaligned is already done in other functions here. Signed-off-by: Stephen Hemminger Reviewed-by: Andrew Rybchenko --- lib/librte_net/rte_ether.h | 17 +++-