Re: [dpdk-dev] [PATCH v5 4/5] mbuf: add a pktmbuf copy routine

2019-10-08 Thread Stephen Hemminger
On Tue, 8 Oct 2019 11:03:34 +0200 Olivier Matz wrote: > > > > +/** > > + * Creates a full copy of a given packet mbuf. > > Although it's not consistent everywhere, I think the imperative > form is preferred ("Create" instead of "Creates"). > > > + * Copies all the data from a given packet m

Re: [dpdk-dev] [PATCH v5 4/5] mbuf: add a pktmbuf copy routine

2019-10-08 Thread Olivier Matz
Hi Stephen, Thank you for this patch. Few comments below. On Mon, Oct 07, 2019 at 08:43:42AM -0700, Stephen Hemminger wrote: > This is a commonly used operation that surprisingly the > DPDK has not supported. The new rte_pktmbuf_copy does a > deep copy of packet. This is a complete copy including

[dpdk-dev] [PATCH v5 4/5] mbuf: add a pktmbuf copy routine

2019-10-07 Thread Stephen Hemminger
This is a commonly used operation that surprisingly the DPDK has not supported. The new rte_pktmbuf_copy does a deep copy of packet. This is a complete copy including meta-data. It handles the case where the source mbuf comes from a pool with larger data area than the destination pool. The routine