Re: [dpdk-dev] [PATCH v5 3/4] vhost: support async dequeue for split ring

2021-07-16 Thread Hu, Jiayu
> -Original Message- > From: David Marchand > Sent: Friday, July 16, 2021 9:53 PM > To: Hu, Jiayu > Cc: Maxime Coquelin ; Ma, WenwuX > ; dev@dpdk.org; Xia, Chenbo > ; Jiang, Cheng1 ; Wang, > YuanX > Subject: Re: [dpdk-dev] [PATCH v5 3/4] vhost: support asy

Re: [dpdk-dev] [PATCH v5 3/4] vhost: support async dequeue for split ring

2021-07-16 Thread David Marchand
On Fri, Jul 16, 2021 at 3:45 PM Hu, Jiayu wrote: > > - I don't like this threshold, this is too low level and most users will > > only see > > the shiny aspect "better performance" without understanding the > > consequences. > > By default, it leaves the door open to a _bad_ behavior, that is pac

Re: [dpdk-dev] [PATCH v5 3/4] vhost: support async dequeue for split ring

2021-07-16 Thread Hu, Jiayu
> -Original Message- > From: David Marchand > Sent: Friday, July 16, 2021 4:15 PM > To: Hu, Jiayu > Cc: Maxime Coquelin ; Ma, WenwuX > ; dev@dpdk.org; Xia, Chenbo > ; Jiang, Cheng1 ; Wang, > YuanX > Subject: Re: [dpdk-dev] [PATCH v5 3/4] vhost: support asy

Re: [dpdk-dev] [PATCH v5 3/4] vhost: support async dequeue for split ring

2021-07-16 Thread Maxime Coquelin
On 7/16/21 9:55 AM, Hu, Jiayu wrote: > > >> -Original Message- >> From: Maxime Coquelin >> Sent: Friday, July 16, 2021 3:46 PM >> To: Hu, Jiayu ; Ma, WenwuX ; >> dev@dpdk.org >> Cc: Xia, Chenbo ; Jiang, Cheng1 >> ; Wang, YuanX >> Subject: Re: [PATCH v5 3/4] vhost: support async deque

Re: [dpdk-dev] [PATCH v5 3/4] vhost: support async dequeue for split ring

2021-07-16 Thread David Marchand
On Wed, Jul 14, 2021 at 8:50 AM Hu, Jiayu wrote: > > Are we ensuring packets are not reordered with this way of working? > > There is a threshold can be set by users. If set it to 0, which presents all > packet copies assigned to the DMA, the packets sent from the guest will > not be reordered. -

Re: [dpdk-dev] [PATCH v5 3/4] vhost: support async dequeue for split ring

2021-07-16 Thread Hu, Jiayu
> -Original Message- > From: Maxime Coquelin > Sent: Friday, July 16, 2021 3:46 PM > To: Hu, Jiayu ; Ma, WenwuX ; > dev@dpdk.org > Cc: Xia, Chenbo ; Jiang, Cheng1 > ; Wang, YuanX > Subject: Re: [PATCH v5 3/4] vhost: support async dequeue for split ring > > Hi, > > On 7/16/21 3:10 AM,

Re: [dpdk-dev] [PATCH v5 3/4] vhost: support async dequeue for split ring

2021-07-16 Thread Maxime Coquelin
Hi, On 7/16/21 3:10 AM, Hu, Jiayu wrote: > Hi, Maxime, > >> -Original Message- >> From: Maxime Coquelin >> Sent: Thursday, July 15, 2021 9:18 PM >> To: Hu, Jiayu ; Ma, WenwuX ; >> dev@dpdk.org >> Cc: Xia, Chenbo ; Jiang, Cheng1 >> ; Wang, YuanX >> Subject: Re: [PATCH v5 3/4] vhost: supp

Re: [dpdk-dev] [PATCH v5 3/4] vhost: support async dequeue for split ring

2021-07-15 Thread Hu, Jiayu
Hi, Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Thursday, July 15, 2021 9:18 PM > To: Hu, Jiayu ; Ma, WenwuX ; > dev@dpdk.org > Cc: Xia, Chenbo ; Jiang, Cheng1 > ; Wang, YuanX > Subject: Re: [PATCH v5 3/4] vhost: support async dequeue for split ring > > > > On 7/14/21

Re: [dpdk-dev] [PATCH v5 3/4] vhost: support async dequeue for split ring

2021-07-15 Thread Maxime Coquelin
On 7/14/21 8:50 AM, Hu, Jiayu wrote: > Hi Maxime, > > Thanks for your comments. Applies are inline. > >> -Original Message- >> From: Maxime Coquelin >> Sent: Tuesday, July 13, 2021 10:30 PM >> To: Ma, WenwuX ; dev@dpdk.org >> Cc: Xia, Chenbo ; Jiang, Cheng1 >> ; Hu, Jiayu ; Wang, Yuan

Re: [dpdk-dev] [PATCH v5 3/4] vhost: support async dequeue for split ring

2021-07-13 Thread Hu, Jiayu
Hi Maxime, Thanks for your comments. Applies are inline. > -Original Message- > From: Maxime Coquelin > Sent: Tuesday, July 13, 2021 10:30 PM > To: Ma, WenwuX ; dev@dpdk.org > Cc: Xia, Chenbo ; Jiang, Cheng1 > ; Hu, Jiayu ; Wang, YuanX > > Subject: Re: [PATCH v5 3/4] vhost: support asyn

Re: [dpdk-dev] [PATCH v5 3/4] vhost: support async dequeue for split ring

2021-07-13 Thread Maxime Coquelin
On 7/5/21 8:11 PM, Wenwu Ma wrote: > From: Yuan Wang > > This patch implements asynchronous dequeue data path for split ring. > A new asynchronous dequeue function is introduced. With this function, > the application can try to receive packets from the guest with > offloading large copies to t

[dpdk-dev] [PATCH v5 3/4] vhost: support async dequeue for split ring

2021-07-04 Thread Wenwu Ma
From: Yuan Wang This patch implements asynchronous dequeue data path for split ring. A new asynchronous dequeue function is introduced. With this function, the application can try to receive packets from the guest with offloading large copies to the DMA engine, thus saving precious CPU cycles. S