Re: [dpdk-dev] [PATCH v5 19/29] app/testpmd: use unicast promiscuous mode on i40e

2016-12-19 Thread Ferruh Yigit
On 12/16/2016 8:28 PM, Vincent JARDIN wrote: > Le 16/12/2016 à 20:02, Ferruh Yigit a écrit : >> +#ifdef RTE_LIBRTE_I40E_PMD >> +ret = rte_pmd_i40e_set_vf_unicast_promisc(res->port_id, >> +res->vf_id, is_on); >> +#endif > > Why is an ifdef used here? It won't scale to all PM

Re: [dpdk-dev] [PATCH v5 19/29] app/testpmd: use unicast promiscuous mode on i40e

2016-12-16 Thread Vincent JARDIN
Le 16/12/2016 à 20:02, Ferruh Yigit a écrit : +#ifdef RTE_LIBRTE_I40E_PMD + ret = rte_pmd_i40e_set_vf_unicast_promisc(res->port_id, + res->vf_id, is_on); +#endif Why is an ifdef used here? It won't scale to all PMDs. I means that you are missing an abstraction layer

[dpdk-dev] [PATCH v5 19/29] app/testpmd: use unicast promiscuous mode on i40e

2016-12-16 Thread Ferruh Yigit
From: Wenzhuo Lu Add testpmd CLI to set VF unicast promiscuous mode on i40e. Signed-off-by: Wenzhuo Lu --- app/test-pmd/cmdline.c | 92 + doc/guides/testpmd_app_ug/testpmd_funcs.rst | 9 +++ 2 files changed, 101 insertions(+) diff --git a/app/