Re: [dpdk-dev] [PATCH v5 1/5] devargs: unify scratch buffer storage

2021-04-16 Thread Aaron Conole
David Marchand writes: > On Tue, Apr 13, 2021 at 5:15 AM Xueming Li wrote: >> diff --git a/lib/librte_eal/include/rte_devargs.h >> b/lib/librte_eal/include/rte_devargs.h >> index 296f19324f..134b44a887 100644 >> --- a/lib/librte_eal/include/rte_devargs.h >> +++ b/lib/librte_eal/include/rte_deva

Re: [dpdk-dev] [PATCH v5 1/5] devargs: unify scratch buffer storage

2021-04-16 Thread David Marchand
On Tue, Apr 13, 2021 at 5:15 AM Xueming Li wrote: > diff --git a/lib/librte_eal/include/rte_devargs.h > b/lib/librte_eal/include/rte_devargs.h > index 296f19324f..134b44a887 100644 > --- a/lib/librte_eal/include/rte_devargs.h > +++ b/lib/librte_eal/include/rte_devargs.h > @@ -60,16 +60,16 @@ stru

[dpdk-dev] [PATCH v5 1/5] devargs: unify scratch buffer storage

2021-04-12 Thread Xueming Li
In current design, legacy parser rte_devargs_parse() saved scratch buffer to devargs.args while new parser rte_devargs_layers_parse() saved to devargs.data. Code using devargs had to know the difference and cleaned up memory accordingly - error prone. This patch unifies scratch buffer to data fiel