Re: [dpdk-dev] [PATCH v5 1/4] vhost: abstract and reorganize async split ring code

2021-04-13 Thread Jiang, Cheng1
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Tuesday, April 13, 2021 3:12 PM > To: Jiang, Cheng1 ; Xia, Chenbo > > Cc: dev@dpdk.org; Hu, Jiayu ; Yang, YvonneX > ; Wang, Yinan ; Liu, > Yong > Subject: Re: [PATCH v5 1/4] vhost: abstract and reorganize async split ring >

Re: [dpdk-dev] [PATCH v5 1/4] vhost: abstract and reorganize async split ring code

2021-04-13 Thread Maxime Coquelin
Hi Cheng, On 4/12/21 1:34 PM, Cheng Jiang wrote: > In order to improve code efficiency and readability when async packed > ring support is enabled. This patch abstract some functions like > shadow_ring_store and write_back_completed_descs_split. And improve > the efficiency of some pointer offset

Re: [dpdk-dev] [PATCH v5 1/4] vhost: abstract and reorganize async split ring code

2021-04-12 Thread Jiang, Cheng1
Hi Jiayu, > -Original Message- > From: Hu, Jiayu > Sent: Tuesday, April 13, 2021 10:44 AM > To: Jiang, Cheng1 ; maxime.coque...@redhat.com; > Xia, Chenbo > Cc: dev@dpdk.org; Yang, YvonneX ; Wang, Yinan > ; Liu, Yong > Subject: RE: [PATCH v5 1/4] vhost: abstract and reorganize async spli

Re: [dpdk-dev] [PATCH v5 1/4] vhost: abstract and reorganize async split ring code

2021-04-12 Thread Hu, Jiayu
Hi Cheng, Some comments inline. > -Original Message- > From: Jiang, Cheng1 > Sent: Monday, April 12, 2021 7:34 PM > To: maxime.coque...@redhat.com; Xia, Chenbo > Cc: dev@dpdk.org; Hu, Jiayu ; Yang, YvonneX > ; Wang, Yinan ; Liu, > Yong ; Jiang, Cheng1 > Subject: [PATCH v5 1/4] vhost: a

[dpdk-dev] [PATCH v5 1/4] vhost: abstract and reorganize async split ring code

2021-04-12 Thread Cheng Jiang
In order to improve code efficiency and readability when async packed ring support is enabled. This patch abstract some functions like shadow_ring_store and write_back_completed_descs_split. And improve the efficiency of some pointer offset calculation. Signed-off-by: Cheng Jiang --- lib/librte_