[dpdk-dev] [PATCH v5 1/3] mempool: support external handler

2016-06-01 Thread Jerin Jacob
On Wed, Jun 01, 2016 at 11:46:20AM +0100, Hunt, David wrote: > > > On 5/31/2016 10:11 PM, Jerin Jacob wrote: > > On Tue, May 31, 2016 at 10:41:00PM +0200, Olivier MATZ wrote: > > > Hi, > > > > > > On 05/31/2016 06:03 PM, Jerin Jacob wrote: > > > > On Tue, May 31, 2016 at 04:37:02PM +0100, Hunt,

[dpdk-dev] [PATCH v5 1/3] mempool: support external handler

2016-06-01 Thread Hunt, David
On 5/31/2016 10:11 PM, Jerin Jacob wrote: > On Tue, May 31, 2016 at 10:41:00PM +0200, Olivier MATZ wrote: >> Hi, >> >> On 05/31/2016 06:03 PM, Jerin Jacob wrote: >>> On Tue, May 31, 2016 at 04:37:02PM +0100, Hunt, David wrote: On 5/31/2016 9:53 AM, Jerin Jacob wrote: > On Mon, May 3

[dpdk-dev] [PATCH v5 1/3] mempool: support external handler

2016-06-01 Thread Jerin Jacob
On Tue, May 31, 2016 at 10:41:00PM +0200, Olivier MATZ wrote: > Hi, > > On 05/31/2016 06:03 PM, Jerin Jacob wrote: > > On Tue, May 31, 2016 at 04:37:02PM +0100, Hunt, David wrote: > >> > >> > >> On 5/31/2016 9:53 AM, Jerin Jacob wrote: > >>> On Mon, May 30, 2016 at 12:27:26PM +0100, Hunt, David wr

[dpdk-dev] [PATCH v5 1/3] mempool: support external handler

2016-05-31 Thread Olivier MATZ
Hi, On 05/31/2016 06:03 PM, Jerin Jacob wrote: > On Tue, May 31, 2016 at 04:37:02PM +0100, Hunt, David wrote: >> >> >> On 5/31/2016 9:53 AM, Jerin Jacob wrote: >>> On Mon, May 30, 2016 at 12:27:26PM +0100, Hunt, David wrote: New mempool handlers will use rte_mempool_create_empty(), rte_m

[dpdk-dev] [PATCH v5 1/3] mempool: support external handler

2016-05-31 Thread Jerin Jacob
On Tue, May 31, 2016 at 04:37:02PM +0100, Hunt, David wrote: > > > On 5/31/2016 9:53 AM, Jerin Jacob wrote: > > On Mon, May 30, 2016 at 12:27:26PM +0100, Hunt, David wrote: > > > New mempool handlers will use rte_mempool_create_empty(), > > > rte_mempool_set_handler(), > > > then rte_mempool_popu

[dpdk-dev] [PATCH v5 1/3] mempool: support external handler

2016-05-31 Thread Hunt, David
On 5/31/2016 9:53 AM, Jerin Jacob wrote: > On Mon, May 30, 2016 at 12:27:26PM +0100, Hunt, David wrote: >> New mempool handlers will use rte_mempool_create_empty(), >> rte_mempool_set_handler(), >> then rte_mempool_populate_*(). These three functions are new to this >> release, to no problem > Ha

[dpdk-dev] [PATCH v5 1/3] mempool: support external handler

2016-05-31 Thread Jerin Jacob
On Mon, May 30, 2016 at 12:27:26PM +0100, Hunt, David wrote: > > New mempool handlers will use rte_mempool_create_empty(), > rte_mempool_set_handler(), > then rte_mempool_populate_*(). These three functions are new to this > release, to no problem Having separate APIs for external pool-manager cr

[dpdk-dev] [PATCH v5 1/3] mempool: support external handler

2016-05-30 Thread Jerin Jacob
On Fri, May 27, 2016 at 03:44:31PM +0100, Hunt, David wrote: > > Hi David, [snip] > That chunk of code above would be better moved all right. I'd suggest > moving it to the > rte_mempool_create function, as that's the one that needs the backward > compatibility. OK > > On the flags issue,

[dpdk-dev] [PATCH v5 1/3] mempool: support external handler

2016-05-30 Thread Hunt, David
On 5/30/2016 10:41 AM, Jerin Jacob wrote: --snip-- >> Of course, that won't help if we need to pass in more data, in which case >> we'd probably need an >> opaque data pointer somewhere. It would probably be most useful to pass it >> in with the >> alloc, which may need the data. Any suggestions?

[dpdk-dev] [PATCH v5 1/3] mempool: support external handler

2016-05-27 Thread Jerin Jacob
On Fri, May 27, 2016 at 10:52:42AM +0100, Hunt, David wrote: > > > On 5/24/2016 4:35 PM, Jerin Jacob wrote: > > On Thu, May 19, 2016 at 02:44:59PM +0100, David Hunt wrote: > > > + /* > > > + * Since we have 4 combinations of the SP/SC/MP/MC examine the flags to > > > + * set the correct index i

[dpdk-dev] [PATCH v5 1/3] mempool: support external handler

2016-05-27 Thread Hunt, David
On 5/27/2016 11:33 AM, Jerin Jacob wrote: > On Fri, May 27, 2016 at 10:52:42AM +0100, Hunt, David wrote: >> >> On 5/24/2016 4:35 PM, Jerin Jacob wrote: >>> On Thu, May 19, 2016 at 02:44:59PM +0100, David Hunt wrote: + /* + * Since we have 4 combinations of the SP/SC/MP/MC examine the

[dpdk-dev] [PATCH v5 1/3] mempool: support external handler

2016-05-27 Thread Hunt, David
On 5/24/2016 4:35 PM, Jerin Jacob wrote: > On Thu, May 19, 2016 at 02:44:59PM +0100, David Hunt wrote: >> +/* >> + * Since we have 4 combinations of the SP/SC/MP/MC examine the flags to >> + * set the correct index into the handler table. >> + */ >> +if (flags & (MEMPOOL_F_SP_

[dpdk-dev] [PATCH v5 1/3] mempool: support external handler

2016-05-24 Thread Jerin Jacob
On Thu, May 19, 2016 at 02:44:59PM +0100, David Hunt wrote: > Until now, the objects stored in mempool mempool were internally stored a > ring. This patch introduce the possibility to register external handlers > replacing the ring. > > The default behavior remains unchanged, but calling the new f

[dpdk-dev] [PATCH v5 1/3] mempool: support external handler

2016-05-19 Thread David Hunt
Until now, the objects stored in mempool mempool were internally stored a ring. This patch introduce the possibility to register external handlers replacing the ring. The default behavior remains unchanged, but calling the new function rte_mempool_set_handler() right after rte_mempool_create_empty