Re: [dpdk-dev] [PATCH v5 1/2] ethdev: add packet integrity checks

2021-04-18 Thread Thomas Monjalon
18/04/2021 10:15, Gregory Etelson: > > > > +__extension__ > > > > > > Why extension here? > > > If this is because of the anonymous union, it should be RTE_STD_C11 > > > before the union. > > > Same for the struct. > > > > > O.K > > The RTE_STD_C11 macro fails compilation on > RHEL-7.9 with gcc v

Re: [dpdk-dev] [PATCH v5 1/2] ethdev: add packet integrity checks

2021-04-18 Thread Gregory Etelson
Hello Thomas, Please see my comment on the use of RTE_STD_C11 below. Regards, Gregory. > > > Currently, DPDK application can offload the checksum check, and > > > report it in the mbuf. > > > > > > However, as more and more applications are offloading some or all > > > logic and action to the HW

Re: [dpdk-dev] [PATCH v5 1/2] ethdev: add packet integrity checks

2021-04-16 Thread Ori Kam
Hi Thomas, > -Original Message- > From: Thomas Monjalon > Sent: Thursday, April 15, 2021 7:46 PM > Subject: Re: [dpdk-dev] [PATCH v5 1/2] ethdev: add packet integrity checks > > 14/04/2021 18:09, Gregory Etelson: > > From: Ori Kam > > > > Current

Re: [dpdk-dev] [PATCH v5 1/2] ethdev: add packet integrity checks

2021-04-15 Thread Ajit Khaparde
> > > However, as more and more applications are offloading some or all > > > logic and action to the HW, there is a need to check the packet > > > integrity so the right decision can be taken. > > > > > > The application logic can be positive meaning if the packet is > > > valid jump / do actions

Re: [dpdk-dev] [PATCH v5 1/2] ethdev: add packet integrity checks

2021-04-15 Thread Thomas Monjalon
14/04/2021 18:09, Gregory Etelson: > From: Ori Kam > > Currently, DPDK application can offload the checksum check, > and report it in the mbuf. > > However, as more and more applications are offloading some or all > logic and action to the HW, there is a need to check the packet > integrity so t

Re: [dpdk-dev] [PATCH v5 1/2] ethdev: add packet integrity checks

2021-04-15 Thread Ori Kam
Hi Ajit, > -Original Message- > From: Ajit Khaparde > Subject: Re: [PATCH v5 1/2] ethdev: add packet integrity checks > > On Wed, Apr 14, 2021 at 9:10 AM Gregory Etelson > wrote: > > > > From: Ori Kam > > > > Currently, DPDK application can offload the checksum check, > > and report it

Re: [dpdk-dev] [PATCH v5 1/2] ethdev: add packet integrity checks

2021-04-14 Thread Ajit Khaparde
On Wed, Apr 14, 2021 at 9:10 AM Gregory Etelson wrote: > > From: Ori Kam > > Currently, DPDK application can offload the checksum check, > and report it in the mbuf. > > However, as more and more applications are offloading some or all > logic and action to the HW, there is a need to check the pa

[dpdk-dev] [PATCH v5 1/2] ethdev: add packet integrity checks

2021-04-14 Thread Gregory Etelson
From: Ori Kam Currently, DPDK application can offload the checksum check, and report it in the mbuf. However, as more and more applications are offloading some or all logic and action to the HW, there is a need to check the packet integrity so the right decision can be taken. The application lo