Re: [dpdk-dev] [PATCH v5 01/19] vhost: fix messages results handling

2018-10-11 Thread Maxime Coquelin
On 10/11/2018 11:32 AM, Ilya Maximets wrote: On 10.10.2018 10:25, Maxime Coquelin wrote: Hi Ilya On 10/09/2018 10:54 PM, Maxime Coquelin wrote: Return of message handling has now changed to an enum that can take non-negative value that is not zero in case a reply is needed. But the code che

Re: [dpdk-dev] [PATCH v5 01/19] vhost: fix messages results handling

2018-10-11 Thread Ilya Maximets
On 10.10.2018 10:25, Maxime Coquelin wrote: > Hi Ilya > > On 10/09/2018 10:54 PM, Maxime Coquelin wrote: >> Return of message handling has now changed to an enum that can >> take non-negative value that is not zero in case a reply is >> needed. But the code checking the variable afterwards has not

Re: [dpdk-dev] [PATCH v5 01/19] vhost: fix messages results handling

2018-10-10 Thread Maxime Coquelin
Hi Ilya On 10/09/2018 10:54 PM, Maxime Coquelin wrote: Return of message handling has now changed to an enum that can take non-negative value that is not zero in case a reply is needed. But the code checking the variable afterwards has not been updated, leading to success messages handling being

[dpdk-dev] [PATCH v5 01/19] vhost: fix messages results handling

2018-10-09 Thread Maxime Coquelin
Return of message handling has now changed to an enum that can take non-negative value that is not zero in case a reply is needed. But the code checking the variable afterwards has not been updated, leading to success messages handling being treated as errors. External post and pre callbacks retur