Re: [dpdk-dev] [PATCH v5 00/15] common ethdev linkstatus functions

2018-01-21 Thread Ferruh Yigit
On 1/19/2018 4:35 PM, Ferruh Yigit wrote: > On 1/17/2018 4:18 PM, Ferruh Yigit wrote: >> On 1/17/2018 4:05 PM, Stephen Hemminger wrote: >>> On Wed, 17 Jan 2018 14:32:17 + >>> Ferruh Yigit wrote: >>> On 1/17/2018 7:56 AM, Andrew Rybchenko wrote: > On 01/16/2018 09:37 PM, Stephen Hemmin

Re: [dpdk-dev] [PATCH v5 00/15] common ethdev linkstatus functions

2018-01-19 Thread Ferruh Yigit
On 1/17/2018 4:18 PM, Ferruh Yigit wrote: > On 1/17/2018 4:05 PM, Stephen Hemminger wrote: >> On Wed, 17 Jan 2018 14:32:17 + >> Ferruh Yigit wrote: >> >>> On 1/17/2018 7:56 AM, Andrew Rybchenko wrote: On 01/16/2018 09:37 PM, Stephen Hemminger wrote: > While reviewing drivers, notice

Re: [dpdk-dev] [PATCH v5 00/15] common ethdev linkstatus functions

2018-01-17 Thread Ferruh Yigit
On 1/17/2018 4:05 PM, Stephen Hemminger wrote: > On Wed, 17 Jan 2018 14:32:17 + > Ferruh Yigit wrote: > >> On 1/17/2018 7:56 AM, Andrew Rybchenko wrote: >>> On 01/16/2018 09:37 PM, Stephen Hemminger wrote: While reviewing drivers, noticed a lot of unnecessary duplication of code i

Re: [dpdk-dev] [PATCH v5 00/15] common ethdev linkstatus functions

2018-01-17 Thread Stephen Hemminger
On Wed, 17 Jan 2018 14:32:17 + Ferruh Yigit wrote: > On 1/17/2018 7:56 AM, Andrew Rybchenko wrote: > > On 01/16/2018 09:37 PM, Stephen Hemminger wrote: > >> While reviewing drivers, noticed a lot of unnecessary > >> duplication of code in drivers for handling the eth_dev link status > >> in

Re: [dpdk-dev] [PATCH v5 00/15] common ethdev linkstatus functions

2018-01-17 Thread Ferruh Yigit
On 1/17/2018 7:56 AM, Andrew Rybchenko wrote: > On 01/16/2018 09:37 PM, Stephen Hemminger wrote: >> While reviewing drivers, noticed a lot of unnecessary >> duplication of code in drivers for handling the eth_dev link status >> information. While consolidating this, it also became obvious that >> s

Re: [dpdk-dev] [PATCH v5 00/15] common ethdev linkstatus functions

2018-01-16 Thread Andrew Rybchenko
On 01/16/2018 09:37 PM, Stephen Hemminger wrote: While reviewing drivers, noticed a lot of unnecessary duplication of code in drivers for handling the eth_dev link status information. While consolidating this, it also became obvious that some drivers behave differently for no good reason. It als

Re: [dpdk-dev] [PATCH v5 00/15] common ethdev linkstatus functions

2018-01-16 Thread Shreyansh Jain
On Wednesday 17 January 2018 12:07 AM, Stephen Hemminger wrote: While reviewing drivers, noticed a lot of unnecessary duplication of code in drivers for handling the eth_dev link status information. While consolidating this, it also became obvious that some drivers behave differently for no good

[dpdk-dev] [PATCH v5 00/15] common ethdev linkstatus functions

2018-01-16 Thread Stephen Hemminger
While reviewing drivers, noticed a lot of unnecessary duplication of code in drivers for handling the eth_dev link status information. While consolidating this, it also became obvious that some drivers behave differently for no good reason. It also was a good chance to introduce atomic exchange pr