Re: [dpdk-dev] [PATCH v5 0/7] hide eth dev related structures

2021-10-11 Thread Andrew Rybchenko
Hi Konstantin, On 10/7/21 2:27 PM, Konstantin Ananyev wrote: > v5 changes: > - Fix spelling (Thomas/David) > - Rename internal helper functions (David) > - Reorder patches and update commit messages (Thomas) > - Update comments (Thomas) > - Changed layout in rte_eth_fp_ops, to group functions and

Re: [dpdk-dev] [PATCH v5 0/7] hide eth dev related structures

2021-10-08 Thread Slava Ovsiienko
Hi, I've reviewed the series, and it looks good to me. I see we did not introduce new indirect referencing on the datapath (just replaced rte_eth_devices[] being hidden with the new rte_eth_fp_ops[].) My only concern - we'll get two places where pointers to the PMDs routines are stored, and it me

[dpdk-dev] [PATCH v5 0/7] hide eth dev related structures

2021-10-07 Thread Konstantin Ananyev
v5 changes: - Fix spelling (Thomas/David) - Rename internal helper functions (David) - Reorder patches and update commit messages (Thomas) - Update comments (Thomas) - Changed layout in rte_eth_fp_ops, to group functions and related data based on their functionality: first 64B line for Rx, se