Re: [dpdk-dev] [PATCH v5] ethdev: check Rx/Tx offloads

2018-04-26 Thread Ferruh Yigit
On 4/26/2018 4:50 PM, Ferruh Yigit wrote: > On 4/26/2018 3:37 PM, Wei Dai wrote: >> This patch check if a requested offloading is supported >> in the device capability. >> Any offloading is disabled by default if it is not set >> in rte_eth_dev_configure( ) and rte_eth_[rt]x_queue_setup(). >> A per

Re: [dpdk-dev] [PATCH v5] ethdev: check Rx/Tx offloads

2018-04-26 Thread Ferruh Yigit
On 4/26/2018 4:56 PM, Thomas Monjalon wrote: > 26/04/2018 17:50, Ferruh Yigit: >> Lets add one more check and consider this for rc1, later we can update checks >> for suggested API in rc2. > > I don't think checks are required for RC1. > Can we take time to properly settle it in RC2? That is OK,

Re: [dpdk-dev] [PATCH v5] ethdev: check Rx/Tx offloads

2018-04-26 Thread Thomas Monjalon
26/04/2018 17:50, Ferruh Yigit: > Lets add one more check and consider this for rc1, later we can update checks > for suggested API in rc2. I don't think checks are required for RC1. Can we take time to properly settle it in RC2?

Re: [dpdk-dev] [PATCH v5] ethdev: check Rx/Tx offloads

2018-04-26 Thread Ferruh Yigit
On 4/26/2018 3:37 PM, Wei Dai wrote: > This patch check if a requested offloading is supported > in the device capability. > Any offloading is disabled by default if it is not set > in rte_eth_dev_configure( ) and rte_eth_[rt]x_queue_setup(). > A per port offloading can only be enabled in > rte_eth

[dpdk-dev] [PATCH v5] ethdev: check Rx/Tx offloads

2018-04-26 Thread Wei Dai
This patch check if a requested offloading is supported in the device capability. Any offloading is disabled by default if it is not set in rte_eth_dev_configure( ) and rte_eth_[rt]x_queue_setup(). A per port offloading can only be enabled in rte_eth_dev_configure(). If a per port offloading is sen