Re: [dpdk-dev] [PATCH v5] ethdev: add sanity checks in control APIs

2021-04-16 Thread Stephen Hemminger
On Thu, 15 Apr 2021 16:38:16 +0100 Ferruh Yigit wrote: > When the line is long, can you break the message part to next line, to reduce > the length at least a few columns, like: > > RTE_ETHDEV_LOG(ERR, > "Failed to setup ethdev port %u Rx hairpin queue to NULL\n", > port_id); > > S

Re: [dpdk-dev] [PATCH v5] ethdev: add sanity checks in control APIs

2021-04-16 Thread Stephen Hemminger
On Thu, 15 Apr 2021 19:09:19 +0800 "Min Hu (Connor)" wrote: > + RTE_ETHDEV_LOG(ERR, "Failed to get owner id by NULL\n"); This message is awkward wording. It would be good time to fix something that has causes problems. Redefine RTE_ETHDEV_LOG to include the function name. There are

Re: [dpdk-dev] [PATCH v5] ethdev: add sanity checks in control APIs

2021-04-16 Thread Min Hu (Connor)
在 2021/4/16 0:21, Thomas Monjalon 写道: 15/04/2021 17:45, Ferruh Yigit: Not exactly related to this patch, but related to the API input, some input that is filled by API is memset first before passing it to the PMD, which makes sense. And for this we have two different ordering with dev_ops che

Re: [dpdk-dev] [PATCH v5] ethdev: add sanity checks in control APIs

2021-04-16 Thread Min Hu (Connor)
Hi, Ferruh, v6 has been sent to fix it, please check it out, thanks. 在 2021/4/15 23:38, Ferruh Yigit 写道: On 4/15/2021 12:09 PM, Min Hu (Connor) wrote: This patch adds more sanity checks in control path APIs. Fixes: 214ed1acd125 ("ethdev: add iterator to match devargs input") Fixes: 3d9

Re: [dpdk-dev] [PATCH v5] ethdev: add sanity checks in control APIs

2021-04-15 Thread Thomas Monjalon
15/04/2021 17:45, Ferruh Yigit: > Not exactly related to this patch, but related to the API input, some input > that > is filled by API is memset first before passing it to the PMD, which makes > sense. And for this we have two different ordering with dev_ops check: > > 1. > memset(input) > che

Re: [dpdk-dev] [PATCH v5] ethdev: add sanity checks in control APIs

2021-04-15 Thread Ferruh Yigit
On 4/15/2021 12:09 PM, Min Hu (Connor) wrote: This patch adds more sanity checks in control path APIs. Fixes: 214ed1acd125 ("ethdev: add iterator to match devargs input") Fixes: 3d98f921fbe9 ("ethdev: unify prefix for static functions and variables") Fixes: 0366137722a0 ("ethdev: check for inval

Re: [dpdk-dev] [PATCH v5] ethdev: add sanity checks in control APIs

2021-04-15 Thread Ferruh Yigit
On 4/15/2021 12:09 PM, Min Hu (Connor) wrote: This patch adds more sanity checks in control path APIs. Fixes: 214ed1acd125 ("ethdev: add iterator to match devargs input") Fixes: 3d98f921fbe9 ("ethdev: unify prefix for static functions and variables") Fixes: 0366137722a0 ("ethdev: check for inval

[dpdk-dev] [PATCH v5] ethdev: add sanity checks in control APIs

2021-04-15 Thread Min Hu (Connor)
This patch adds more sanity checks in control path APIs. Fixes: 214ed1acd125 ("ethdev: add iterator to match devargs input") Fixes: 3d98f921fbe9 ("ethdev: unify prefix for static functions and variables") Fixes: 0366137722a0 ("ethdev: check for invalid device name") Fixes: d948f596fee2 ("ethdev: f