Re: [dpdk-dev] [PATCH v5] app/testpmd: fix setting maximum packet length

2021-01-28 Thread Lance Richardson
On Tue, Jan 26, 2021 at 6:01 AM Ferruh Yigit wrote: > > On 1/26/2021 3:45 AM, Lance Richardson wrote: > > On Mon, Jan 25, 2021 at 7:44 PM Ferruh Yigit wrote: > >> > + if (rx_offloads != port->dev_conf.rxmode.offloads) { > + uint16_t qid; > + > +

Re: [dpdk-dev] [PATCH v5] app/testpmd: fix setting maximum packet length

2021-01-28 Thread Wisam Monther
> -Original Message- > From: Ferruh Yigit > Sent: Thursday, January 28, 2021 11:27 AM > To: Wisam Monther ; Wenzhuo Lu > ; Xiaoyun Li ; Bernard > Iremonger ; Steve Yang > > Cc: dev@dpdk.org; sta...@dpdk.org; lance.richard...@broadcom.com; > ouli...@huawei.com; lihuis...@huawei.com > Sub

Re: [dpdk-dev] [PATCH v5] app/testpmd: fix setting maximum packet length

2021-01-28 Thread Ferruh Yigit
On 1/28/2021 9:18 AM, Wisam Monther wrote: Hi Ferruh, -Original Message- From: Ferruh Yigit Sent: Monday, January 25, 2021 8:16 PM To: Wenzhuo Lu ; Xiaoyun Li ; Bernard Iremonger ; Steve Yang Cc: Ferruh Yigit ; dev@dpdk.org; sta...@dpdk.org; lance.richard...@broadcom.com; ouli...@hua

Re: [dpdk-dev] [PATCH v5] app/testpmd: fix setting maximum packet length

2021-01-28 Thread Wisam Monther
Hi Ferruh, > -Original Message- > From: Ferruh Yigit > Sent: Monday, January 25, 2021 8:16 PM > To: Wenzhuo Lu ; Xiaoyun Li > ; Bernard Iremonger > ; Steve Yang > Cc: Ferruh Yigit ; dev@dpdk.org; sta...@dpdk.org; > lance.richard...@broadcom.com; ouli...@huawei.com; Wisam Monther > ; lih

Re: [dpdk-dev] [PATCH v5] app/testpmd: fix setting maximum packet length

2021-01-27 Thread Chen, BoX C
...@mellanox.com; lihuis...@huawei.com > Subject: Re: [dpdk-dev] [PATCH v5] app/testpmd: fix setting maximum > packet length > > Except a minor typo inline. > Acked-by: Xiaoyun Li > Tested-by: Chen, BoX C

Re: [dpdk-dev] [PATCH v5] app/testpmd: fix setting maximum packet length

2021-01-26 Thread Li, Xiaoyun
Except a minor typo inline. Acked-by: Xiaoyun Li > -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, January 26, 2021 02:16 > To: Lu, Wenzhuo ; Li, Xiaoyun ; > Iremonger, Bernard ; Yang, SteveX > > Cc: Yigit, Ferruh ; dev@dpdk.org; sta...@dpdk.org; > lance.richard...@broadcom.co

Re: [dpdk-dev] [PATCH v5] app/testpmd: fix setting maximum packet length

2021-01-26 Thread Ferruh Yigit
On 1/26/2021 3:45 AM, Lance Richardson wrote: On Mon, Jan 25, 2021 at 7:44 PM Ferruh Yigit wrote: + if (rx_offloads != port->dev_conf.rxmode.offloads) { + uint16_t qid; + + port->dev_conf.rxmode.offloads = rx_offloads; + + /* Apply JUMBO_FRAME o

Re: [dpdk-dev] [PATCH v5] app/testpmd: fix setting maximum packet length

2021-01-26 Thread Wisam Monther
Hi, > -Original Message- > From: Ferruh Yigit > Sent: Monday, January 25, 2021 8:16 PM > To: Wenzhuo Lu ; Xiaoyun Li > ; Bernard Iremonger > ; Steve Yang > Cc: Ferruh Yigit ; dev@dpdk.org; sta...@dpdk.org; > lance.richard...@broadcom.com; ouli...@huawei.com; Wisam Monther > ; lihuis...@h

Re: [dpdk-dev] [PATCH v5] app/testpmd: fix setting maximum packet length

2021-01-25 Thread Li, Xiaoyun
> -Original Message- > From: Lance Richardson > Sent: Tuesday, January 26, 2021 11:45 > To: Yigit, Ferruh > Cc: Lu, Wenzhuo ; Li, Xiaoyun ; > Iremonger, Bernard ; Yang, SteveX > ; dev@dpdk.org; sta...@dpdk.org; > ouli...@huawei.com; wis...@mellanox.com; lihuis...@huawei.com > Subject: R

Re: [dpdk-dev] [PATCH v5] app/testpmd: fix setting maximum packet length

2021-01-25 Thread Lance Richardson
On Mon, Jan 25, 2021 at 7:44 PM Ferruh Yigit wrote: > > >> + if (rx_offloads != port->dev_conf.rxmode.offloads) { > >> + uint16_t qid; > >> + > >> + port->dev_conf.rxmode.offloads = rx_offloads; > >> + > >> + /* Apply JUMBO_FRAME offload configuratio

Re: [dpdk-dev] [PATCH v5] app/testpmd: fix setting maximum packet length

2021-01-25 Thread Lance Richardson
Acked-by: Lance Richardson Thanks, Lance On Mon, Jan 25, 2021 at 7:44 PM Ferruh Yigit wrote: > > On 1/25/2021 7:41 PM, Lance Richardson wrote: > > On Mon, Jan 25, 2021 at 1:15 PM Ferruh Yigit wrote: > >> > >> From: Steve Yang > >> > >> "port config all max-pkt-len" command fails because i

Re: [dpdk-dev] [PATCH v5] app/testpmd: fix setting maximum packet length

2021-01-25 Thread Ferruh Yigit
On 1/25/2021 7:41 PM, Lance Richardson wrote: On Mon, Jan 25, 2021 at 1:15 PM Ferruh Yigit wrote: From: Steve Yang "port config all max-pkt-len" command fails because it doesn't set the 'DEV_RX_OFFLOAD_JUMBO_FRAME' offload flag properly. Commit in the fixes line moved the 'DEV_RX_OFFLOAD_JU

Re: [dpdk-dev] [PATCH v5] app/testpmd: fix setting maximum packet length

2021-01-25 Thread Lance Richardson
On Mon, Jan 25, 2021 at 1:15 PM Ferruh Yigit wrote: > > From: Steve Yang > > "port config all max-pkt-len" command fails because it doesn't set the > 'DEV_RX_OFFLOAD_JUMBO_FRAME' offload flag properly. > > Commit in the fixes line moved the 'DEV_RX_OFFLOAD_JUMBO_FRAME' offload > flag update from

[dpdk-dev] [PATCH v5] app/testpmd: fix setting maximum packet length

2021-01-25 Thread Ferruh Yigit
From: Steve Yang "port config all max-pkt-len" command fails because it doesn't set the 'DEV_RX_OFFLOAD_JUMBO_FRAME' offload flag properly. Commit in the fixes line moved the 'DEV_RX_OFFLOAD_JUMBO_FRAME' offload flag update from 'cmd_config_max_pkt_len_parsed()' to 'init_config()'. 'init_config(