>
> Minor observations which are things that checkpatch etc won't see but make
> the code easier to read/maintain.
>
> > +/* border variable to hold for show */ char bdr_str[MAX_STRING_LEN];
Done for v5
>
> Does this have to be global, could it just be static?
>
> > + memset(&link,
> > + snprintf(bdr_str, 100, " Port (%u)", i);
>
> %s/100/MAX_STRING_LEN ?
Done for v5
>
> > + ret = rte_eth_dev_rss_hash_conf_get(i, &rss_conf);
> > + if ((ret) || (rss_conf.rss_key == NULL))
> > + continue;
> > +
>
On Tue, 6 Nov 2018 18:19:07 +0530
Vipin Varghese wrote:
Minor observations which are things that checkpatch etc won't see
but make the code easier to read/maintain.
> +/* border variable to hold for show */
> +char bdr_str[MAX_STRING_LEN];
Does this have to be global, could it just be static?
> -Original Message-
> From: Varghese, Vipin
> Sent: Tuesday, November 6, 2018 12:49 PM
> To: dev@dpdk.org; tho...@monjalon.net; Pattan, Reshma
> ; step...@networkplumber.org; Mcnamara, John
>
> Cc: Byrne, Stephen1 ; Glynn, Michael J
> ; Patel, Amol ; Varghese,
> Vipin
> Subject: [PATC
Function show_port is used for displaying the port PMD information under
under primary process. The information shows basic, per queue and security.
Signed-off-by: Vipin Varghese
---
V3:
- fix meson build - Reshma Pattan
- change 100 to MAX_STRING_LEN - Reshma Pattan
- memset to struct elemen
Function show_port is used for displaying the port PMD information under
under primary process. The information shows basic, per queue and security.
Signed-off-by: Vipin Varghese
---
V3:
- fix meson build - Reshma Pattan
- change 100 to MAX_STRING_LEN - Reshma Pattan
- memset to struct elemen
6 matches
Mail list logo
