> -Original Message-
> From: Honnappa Nagarahalli
> Sent: Monday, November 2, 2020 8:32 PM
> To: Juraj Linkeš ; bruce.richard...@intel.com;
> Ruifeng Wang ; Phil Yang ;
> vcchu...@amazon.com; Dharmik Thakkar ;
> jerinjac...@gmail.com; hemant.agra...@nxp.com
> Cc: dev@dpdk.org; nd ; Honna
> > > >
> > > > > diff --git a/config/arm/meson.build b/config/arm/meson.build
> > > > > index
> > > > > 491842cad..6c31ab167 100644
> > > > > --- a/config/arm/meson.build
> > > > > +++ b/config/arm/meson.build
> > > > > @@ -3,12 +3,12 @@
> > > > > # Copyright(c) 2017 Cavium, Inc # Copyright(c)
> -Original Message-
> From: Honnappa Nagarahalli
> Sent: Thursday, October 29, 2020 9:54 PM
> To: Juraj Linkeš ; bruce.richard...@intel.com;
> Ruifeng Wang ; Phil Yang ;
> vcchu...@amazon.com; Dharmik Thakkar ;
> jerinjac...@gmail.com; hemant.agra...@nxp.com
> Cc: dev@dpdk.org; nd ; Hon
> >
> >
> > > diff --git a/config/arm/meson.build b/config/arm/meson.build index
> > > 491842cad..6c31ab167 100644
> > > --- a/config/arm/meson.build
> > > +++ b/config/arm/meson.build
> > > @@ -3,12 +3,12 @@
> > > # Copyright(c) 2017 Cavium, Inc
> > > # Copyright(c) 2020 PANTHEON.tech s.r.o.
>
> -Original Message-
> From: Honnappa Nagarahalli
> Sent: Wednesday, October 28, 2020 5:59 PM
> To: Juraj Linkeš ; bruce.richard...@intel.com;
> Ruifeng Wang ; Phil Yang ;
> vcchu...@amazon.com; Dharmik Thakkar ;
> jerinjac...@gmail.com; hemant.agra...@nxp.com
> Cc: dev@dpdk.org; nd ; Ho
>
> * Rename variables to have names that better describe what the variables
> store
> * Remove unused or superfluous variables
> * Change a list to dictionary where key lookup is needed
> * Add informatory comments in the code
> * Minor code restructure and reformatting
>
> Signed-off-by: Jura
> >
> > > > flags_emag = [
> > > > ['RTE_MACHINE', '"emag"'],
> > > > - ['RTE_CACHE_LINE_SIZE', 64],
> > > > ['RTE_MAX_NUMA_NODES', 1],
> > > > - ['RTE_MAX_LCORE', 32]]
> > > > + ['RTE_MAX_LCORE', 32],
> > > > + ['RTE_CACHE_LINE_SIZE', 64]
> > > > +]
> > >
> > I think we need to split this further. Few suggestions below.
> >
> > >
> > > * Rename variables to have names that better describe what the
> > > variables store
> > This should be a separate commit.
> >
> > > * Remove unused or superfluous variables
> > Same here
> >
> > > * Change a list t
gra...@nxp.com
> Cc: dev@dpdk.org; nd ; nd
> Subject: Re: [dpdk-dev] [PATCH v4 2/6] build: refactor Arm build
>
>
>
> > -Original Message-
> > From: Honnappa Nagarahalli
> > Sent: Tuesday, October 27, 2020 5:56 AM
> > To: Juraj Linkeš ;
>
> -Original Message-
> From: Honnappa Nagarahalli
> Sent: Tuesday, October 27, 2020 5:56 AM
> To: Juraj Linkeš ; bruce.richard...@intel.com;
> Ruifeng Wang ; Phil Yang ;
> vcchu...@amazon.com; Dharmik Thakkar ;
> jerinjac...@gmail.com; hemant.agra...@nxp.com
> Cc: dev@dpdk.org; nd ; Honn
I think we need to split this further. Few suggestions below.
>
> * Rename variables to have names that better describe what the variables
> store
This should be a separate commit.
> * Remove unused or superfluous variables
Same here
> * Change a list to dictionary where key lookup is needed
S
* Rename variables to have names that better describe what the variables
store
* Remove unused or superfluous variables
* Change a list to dictionary where key lookup is needed
* Add informatory comments in the code
* Minor code restructure and reformatting
Signed-off-by: Juraj Linkeš
---
config
12 matches
Mail list logo
