Re: [dpdk-dev] [PATCH v4 1/7] net/ark: PMD for Atomic Rules Arkville driver stub

2017-03-29 Thread Ferruh Yigit
On 3/28/2017 10:11 PM, Ed Czeck wrote: > On Tue, Mar 28, 2017 at 8:58 AM, Ferruh Yigit > wrote: > > On 3/23/2017 7:46 PM, Ed Czeck wrote: > > >> > +#define ARK_TRACE_ON(fmt, ...) \ > >> > + PMD_DRV_LOG(ERR, fmt, ##__VA_ARGS__) > >> > + > >>

Re: [dpdk-dev] [PATCH v4 1/7] net/ark: PMD for Atomic Rules Arkville driver stub

2017-03-28 Thread Ed Czeck
On Tue, Mar 28, 2017 at 8:58 AM, Ferruh Yigit wrote: > On 3/23/2017 7:46 PM, Ed Czeck wrote: > > >> > +#define ARK_TRACE_ON(fmt, ...) \ > >> > + PMD_DRV_LOG(ERR, fmt, ##__VA_ARGS__) > >> > + > >> > +#define ARK_TRACE_OFF(fmt, ...) \ > >> > + do {if (0) PMD_DRV_LOG(ERR, fmt, ##__VA_ARGS__)

Re: [dpdk-dev] [PATCH v4 1/7] net/ark: PMD for Atomic Rules Arkville driver stub

2017-03-28 Thread Ferruh Yigit
On 3/23/2017 7:46 PM, Ed Czeck wrote: >> > +#define ARK_TRACE_ON(fmt, ...) \ >> > + PMD_DRV_LOG(ERR, fmt, ##__VA_ARGS__) >> > + >> > +#define ARK_TRACE_OFF(fmt, ...) \ >> > + do {if (0) PMD_DRV_LOG(ERR, fmt, ##__VA_ARGS__); } while (0) >> why not just "do { } while(0)" ? > > A do while bo

Re: [dpdk-dev] [PATCH v4 1/7] net/ark: PMD for Atomic Rules Arkville driver stub

2017-03-23 Thread Ed Czeck
In the next patch set, v5 the following are addressed. > > > > +CONFIG_RTE_LIBRTE_ARK_PMD=n > Is it not tested or known that it is not supported? > > CONFIG_RTE_LIBRTE_IXGBE_PMD=n > > CONFIG_RTE_LIBRTE_I40E_PMD=n > > CONFIG_RTE_LIBRTE_VIRTIO_PMD=y The Ark/PMD is not supported on those architect

Re: [dpdk-dev] [PATCH v4 1/7] net/ark: PMD for Atomic Rules Arkville driver stub

2017-03-23 Thread Ferruh Yigit
On 3/23/2017 1:03 AM, Ed Czeck wrote: > Enable Arkville on supported configurations > Add overview documentation > Minimum driver support for valid compile > Arkville PMD is not supported on ARM or PowerPC at this time > > v4: > * Address issues report from review > * Add internal comments on driv

Re: [dpdk-dev] [PATCH v4 1/7] net/ark: PMD for Atomic Rules Arkville driver stub

2017-03-23 Thread Ferruh Yigit
On 3/23/2017 1:03 AM, Ed Czeck wrote: > Enable Arkville on supported configurations > Add overview documentation > Minimum driver support for valid compile > Arkville PMD is not supported on ARM or PowerPC at this time Can you please send new version of patchset as reply to previous version, using

[dpdk-dev] [PATCH v4 1/7] net/ark: PMD for Atomic Rules Arkville driver stub

2017-03-22 Thread Ed Czeck
Enable Arkville on supported configurations Add overview documentation Minimum driver support for valid compile Arkville PMD is not supported on ARM or PowerPC at this time v4: * Address issues report from review * Add internal comments on driver arg * provide a bare-biones dev init to avoid compi