Re: [dpdk-dev] [PATCH v4 1/2] mbuf: use C11 atomic built-ins for refcnt operations

2020-07-16 Thread Phil Yang
> On Thu, Jul 16, 2020 at 3:21 PM Dodji Seketeli wrote: > > Just for the sake of precision, I'd like to say that in the coming 1.8 > > version of libabigail, this change won't be reported by the tooling as a > > problem anymore. This is thanks to David filing the feature request > > https://sou

Re: [dpdk-dev] [PATCH v4 1/2] mbuf: use C11 atomic built-ins for refcnt operations

2020-07-16 Thread David Marchand
On Thu, Jul 16, 2020 at 3:21 PM Dodji Seketeli wrote: > Just for the sake of precision, I'd like to say that in the coming 1.8 > version of libabigail, this change won't be reported by the tooling as a > problem anymore. This is thanks to David filing the feature request > https://sourceware.org/

Re: [dpdk-dev] [PATCH v4 1/2] mbuf: use C11 atomic built-ins for refcnt operations

2020-07-16 Thread Dodji Seketeli
Hello, David Marchand writes: [...] On Thu, Jul 16, 2020 at 6:16 AM Phil Yang wrote: >> > >> > v4 does not pass the checks (in both my env, and Travis). >> > https://travis-ci.com/github/ovsrobot/dpdk/jobs/359393389#L2405 >> >> I think we need an exception in 'libabigail.abignore' for this ch

Re: [dpdk-dev] [PATCH v4 1/2] mbuf: use C11 atomic built-ins for refcnt operations

2020-07-16 Thread Olivier Matz
On Thu, Jul 09, 2020 at 11:58:50PM +0800, Phil Yang wrote: > Use C11 atomic built-ins with explicit ordering instead of rte_atomic > ops which enforce unnecessary barriers on aarch64. > > Signed-off-by: Phil Yang > Reviewed-by: Ruifeng Wang Acked-by: Olivier Matz Thanks

Re: [dpdk-dev] [PATCH v4 1/2] mbuf: use C11 atomic built-ins for refcnt operations

2020-07-16 Thread David Marchand
On Thu, Jul 16, 2020 at 6:16 AM Phil Yang wrote: > > David Marchand writes: > > > Subject: Re: [PATCH v4 1/2] mbuf: use C11 atomic built-ins for refcnt > > operations > > > > On Thu, Jul 9, 2020 at 5:59 PM Phil Yang wrote: > > > > > > Use C11 atomic built-ins with explicit ordering instead of rt

Re: [dpdk-dev] [PATCH v4 1/2] mbuf: use C11 atomic built-ins for refcnt operations

2020-07-15 Thread Phil Yang
David Marchand writes: > Subject: Re: [PATCH v4 1/2] mbuf: use C11 atomic built-ins for refcnt > operations > > On Thu, Jul 9, 2020 at 5:59 PM Phil Yang wrote: > > > > Use C11 atomic built-ins with explicit ordering instead of rte_atomic > > ops which enforce unnecessary barriers on aarch64. >

Re: [dpdk-dev] [PATCH v4 1/2] mbuf: use C11 atomic built-ins for refcnt operations

2020-07-15 Thread Phil Yang
> -Original Message- > From: David Marchand > Sent: Wednesday, July 15, 2020 8:29 PM > To: Phil Yang > Cc: Olivier Matz ; dev ; Stephen > Hemminger ; David Christensen > ; Honnappa Nagarahalli > ; Ruifeng Wang > ; nd ; Dodji Seketeli > ; Aaron Conole > Subject: Re: [PATCH v4 1/2] mbuf: u

Re: [dpdk-dev] [PATCH v4 1/2] mbuf: use C11 atomic built-ins for refcnt operations

2020-07-15 Thread Aaron Conole
David Marchand writes: > On Thu, Jul 9, 2020 at 5:59 PM Phil Yang wrote: >> >> Use C11 atomic built-ins with explicit ordering instead of rte_atomic >> ops which enforce unnecessary barriers on aarch64. >> >> Signed-off-by: Phil Yang >> Reviewed-by: Ruifeng Wang >> --- >> v4: >> 1. Add union f

Re: [dpdk-dev] [PATCH v4 1/2] mbuf: use C11 atomic built-ins for refcnt operations

2020-07-15 Thread David Marchand
On Thu, Jul 9, 2020 at 5:59 PM Phil Yang wrote: > > Use C11 atomic built-ins with explicit ordering instead of rte_atomic > ops which enforce unnecessary barriers on aarch64. > > Signed-off-by: Phil Yang > Reviewed-by: Ruifeng Wang > --- > v4: > 1. Add union for refcnt_atomic and refcnt in rte_m

[dpdk-dev] [PATCH v4 1/2] mbuf: use C11 atomic built-ins for refcnt operations

2020-07-09 Thread Phil Yang
Use C11 atomic built-ins with explicit ordering instead of rte_atomic ops which enforce unnecessary barriers on aarch64. Signed-off-by: Phil Yang Reviewed-by: Ruifeng Wang --- v4: 1. Add union for refcnt_atomic and refcnt in rte_mbuf_ext_shared_info to avoid ABI breakage. (Olivier) 2. Add notice