Re: [dpdk-dev] [PATCH v4 1/2] gro: add UDP GRO support

2020-09-10 Thread yang_y_yi
[dpdk-dev] [PATCH v4 1/2] gro: add UDP GRO support Importance: High This is incremental patch to fix your new comments, I'll send out v5 if no more comments here. diff --git a/lib/librte_gro/gro_udp4.c b/lib/librte_gro/gro_udp4.c index 25584fd..061e7b0 100644 --- a/lib/librte_gro/gro_u

Re: [dpdk-dev] [PATCH v4 1/2] gro: add UDP GRO support

2020-09-09 Thread Hu, Jiayu
No more comments on this patch. Thanks, Jiayu From: yang_y_yi Sent: Wednesday, September 9, 2020 5:00 PM To: Hu, Jiayu Cc: tho...@monjalon.net; dev@dpdk.org; yangy...@inspur.com Subject: Re:Re: [dpdk-dev] [PATCH v4 1/2] gro: add UDP GRO support Importance: High This is incremental patch to

Re: [dpdk-dev] [PATCH v4 1/2] gro: add UDP GRO support

2020-09-09 Thread yang_y_yi
This is incremental patch to fix your new comments, I'll send out v5 if no more comments here. diff --git a/lib/librte_gro/gro_udp4.c b/lib/librte_gro/gro_udp4.c index 25584fd..061e7b0 100644 --- a/lib/librte_gro/gro_udp4.c +++ b/lib/librte_gro/gro_udp4.c @@ -107,7 +107,7 @@ uint32_t i

Re: [dpdk-dev] [PATCH v4 1/2] gro: add UDP GRO support

2020-09-09 Thread yang_y_yi
At 2020-09-08 10:05:16, "Jiayu Hu" wrote: >Some comments are inline. Thanks, replies inline. > >Thanks, >Jiayu > >On Fri, Sep 04, 2020 at 04:37:39PM +0800, yang_y...@163.com wrote: >> From: Yi Yang >> >> UDP GRO can help improve VM-to-VM UDP performance when >> VM is enabled UFO or GSO, GRO

Re: [dpdk-dev] [PATCH v4 1/2] gro: add UDP GRO support

2020-09-07 Thread Jiayu Hu
Some comments are inline. Thanks, Jiayu On Fri, Sep 04, 2020 at 04:37:39PM +0800, yang_y...@163.com wrote: > From: Yi Yang > > UDP GRO can help improve VM-to-VM UDP performance when > VM is enabled UFO or GSO, GRO must be supported if GSO > or UFO is enabled, otherwise, performance gain will be

[dpdk-dev] [PATCH v4 1/2] gro: add UDP GRO support

2020-09-04 Thread yang_y_yi
From: Yi Yang UDP GRO can help improve VM-to-VM UDP performance when VM is enabled UFO or GSO, GRO must be supported if GSO or UFO is enabled, otherwise, performance gain will be hurt. With this enabled in DPDK, OVS DPDK can leverage it to improve VM-to-VM UDP performance, this will make sure IP