Re: [dpdk-dev] [PATCH v4 07/11] eal: replace rte_panic instances in hugepage_info

2018-04-20 Thread Arnon Warshavsky
Now clear.Thanks On Thu, Apr 19, 2018 at 5:50 PM, Burakov, Anatoly wrote: > On 19-Apr-18 3:45 PM, Burakov, Anatoly wrote: > >> On 19-Apr-18 3:09 PM, Arnon Warshavsky wrote: >> >>> Thanks Anatoly. Will fix that in v5. >>> Is it preferred to keep all version notes in the cover letter alone? >>> >>

Re: [dpdk-dev] [PATCH v4 07/11] eal: replace rte_panic instances in hugepage_info

2018-04-20 Thread Arnon Warshavsky
Thanks Kevin Will address that On Thu, Apr 19, 2018 at 5:36 PM, Kevin Traynor wrote: > On 04/19/2018 07:01 AM, Arnon Warshavsky wrote: > > replace panic calls with log and retrun value. > > > > v4 > > static size calculation function changed to return success/fail code > > in addition to filling

Re: [dpdk-dev] [PATCH v4 07/11] eal: replace rte_panic instances in hugepage_info

2018-04-19 Thread Burakov, Anatoly
On 19-Apr-18 3:45 PM, Burakov, Anatoly wrote: On 19-Apr-18 3:09 PM, Arnon Warshavsky wrote: Thanks Anatoly. Will fix that in v5. Is it preferred to keep all version notes in the cover letter alone? Generally, cover letter should give general outline (i.e. "fixed 32 bit compile"), while notes

Re: [dpdk-dev] [PATCH v4 07/11] eal: replace rte_panic instances in hugepage_info

2018-04-19 Thread Burakov, Anatoly
On 19-Apr-18 3:09 PM, Arnon Warshavsky wrote: Thanks Anatoly. Will fix that in v5. Is it preferred to keep all version notes in the cover letter alone? Generally, cover letter should give general outline (i.e. "fixed 32 bit compile"), while notes for individual patches should be more specific

Re: [dpdk-dev] [PATCH v4 07/11] eal: replace rte_panic instances in hugepage_info

2018-04-19 Thread Kevin Traynor
On 04/19/2018 07:01 AM, Arnon Warshavsky wrote: > replace panic calls with log and retrun value. > > v4 > static size calculation function changed to return success/fail code > in addition to filling the size result. > fyi - this patch doesn't apply on master branch without fuzz > Signed-off-b

Re: [dpdk-dev] [PATCH v4 07/11] eal: replace rte_panic instances in hugepage_info

2018-04-19 Thread Arnon Warshavsky
Thanks Anatoly. Will fix that in v5. Is it preferred to keep all version notes in the cover letter alone? On Thu, Apr 19, 2018 at 5:03 PM, Burakov, Anatoly wrote: > On 19-Apr-18 7:01 AM, Arnon Warshavsky wrote: > >> replace panic calls with log and retrun value. >> > > typo: return > > >> v4 >>

Re: [dpdk-dev] [PATCH v4 07/11] eal: replace rte_panic instances in hugepage_info

2018-04-19 Thread Burakov, Anatoly
On 19-Apr-18 7:01 AM, Arnon Warshavsky wrote: replace panic calls with log and retrun value. typo: return v4 static size calculation function changed to return success/fail code in addition to filling the size result. Signed-off-by: Arnon Warshavsky --- Please do not add version notes t

[dpdk-dev] [PATCH v4 07/11] eal: replace rte_panic instances in hugepage_info

2018-04-18 Thread Arnon Warshavsky
replace panic calls with log and retrun value. v4 static size calculation function changed to return success/fail code in addition to filling the size result. Signed-off-by: Arnon Warshavsky --- lib/librte_eal/linuxapp/eal/eal_hugepage_info.c | 32 - 1 file changed, 21