Re: [dpdk-dev] [PATCH v4 04/11] ixgbe: replace rte_panic instances in ixgbe driver

2018-04-20 Thread Arnon Warshavsky
> On 04/19/2018 07:01 AM, Arnon Warshavsky wrote: > > replace panic calls with log and retrun value. > > typo return, seems to be in a few commit msgs > Yup. They were not even copy pasted so at least I am consistent :) > + return -1; > > similar comment as previous patch about using

Re: [dpdk-dev] [PATCH v4 04/11] ixgbe: replace rte_panic instances in ixgbe driver

2018-04-19 Thread Kevin Traynor
On 04/19/2018 07:01 AM, Arnon Warshavsky wrote: > replace panic calls with log and retrun value. typo return, seems to be in a few commit msgs > Local function to this file, > changing from void to int is non-abi-breaking > > Signed-off-by: Arnon Warshavsky > --- > drivers/net/ixgbe/ixgbe_ethd

[dpdk-dev] [PATCH v4 04/11] ixgbe: replace rte_panic instances in ixgbe driver

2018-04-18 Thread Arnon Warshavsky
replace panic calls with log and retrun value. Local function to this file, changing from void to int is non-abi-breaking Signed-off-by: Arnon Warshavsky --- drivers/net/ixgbe/ixgbe_ethdev.c | 3 ++- drivers/net/ixgbe/ixgbe_ethdev.h | 2 +- drivers/net/ixgbe/ixgbe_pf.c | 13 +