Re: [dpdk-dev] [PATCH v4 02/16] net/mrvl: add mrvl net pmd driver skeleton

2017-10-12 Thread Vincent JARDIN
Le 12/10/2017 à 14:14, Jacek Siuda a écrit : What we can do, is to add a run-time driver option and oblige user (in documentation) to set the option only for the first mrvl vdev. If the driver doesn't see the option set, it  won't initialize DMA. This, plus meaningful error handling/logs shou

Re: [dpdk-dev] [PATCH v4 02/16] net/mrvl: add mrvl net pmd driver skeleton

2017-10-12 Thread Jacek Siuda
Hi, The problem is, that both drivers are totally separate entities, linked into separate libs, but we need to use only one setting in both of them. So, in order to provide any runtime (or even compile-time) verification, we would need to create a third entity just to handle a simple assertion - a

Re: [dpdk-dev] [PATCH v4 02/16] net/mrvl: add mrvl net pmd driver skeleton

2017-10-12 Thread Vincent JARDIN
+1 with Thomas, see below, Le 12/10/2017 à 08:51, Tomasz Duszynski a écrit : What is MUSDK_DMA_MEMSIZE? If the value cannot change, it must be a constant in the code. If it can change, it should be a run-time driver option. It's up to the user what MUSDK_DMA_MEMSIZE is going to be. Currently it

Re: [dpdk-dev] [PATCH v4 02/16] net/mrvl: add mrvl net pmd driver skeleton

2017-10-11 Thread Tomasz Duszynski
On Wed, Oct 11, 2017 at 03:38:36PM +0200, Thomas Monjalon wrote: > Hi, > > 09/10/2017 17:00, Tomasz Duszynski: > > # > > +# Compile Marvell PMD driver > > +# > > +CONFIG_RTE_LIBRTE_MRVL_PMD=n > > +CONFIG_RTE_LIBRTE_MRVL_DEBUG=n > > +CONFIG_RTE_MRVL_MUSDK_DMA_MEMSIZE=41943040 > > We are trying to r

Re: [dpdk-dev] [PATCH v4 02/16] net/mrvl: add mrvl net pmd driver skeleton

2017-10-11 Thread Thomas Monjalon
Hi, 09/10/2017 17:00, Tomasz Duszynski: > # > +# Compile Marvell PMD driver > +# > +CONFIG_RTE_LIBRTE_MRVL_PMD=n > +CONFIG_RTE_LIBRTE_MRVL_DEBUG=n > +CONFIG_RTE_MRVL_MUSDK_DMA_MEMSIZE=41943040 We are trying to remove build-time configurations and behave like a true library. The DEBUG config opt

[dpdk-dev] [PATCH v4 02/16] net/mrvl: add mrvl net pmd driver skeleton

2017-10-09 Thread Tomasz Duszynski
Add mrvl net pmd driver skeleton providing base for the further development. Besides the basic functionality QoS configuration is introduced as well. Signed-off-by: Jacek Siuda Signed-off-by: Tomasz Duszynski --- config/common_base|7 + doc/guides/rel_notes/release_1