[dpdk-dev] [PATCH v3 6/6] mk: prevent overlinking in applications

2016-06-13 Thread Christian Ehrhardt
Hi, great work on cleaning that up already. I applied v3 of the series and see already much better results. But I found some more that should be part of this. I don't know how generally available a similar solution is, but usually in our build dpkg-shlibdeps checks for under/overlinking issues. I

[dpdk-dev] [PATCH v3 6/6] mk: prevent overlinking in applications

2016-06-13 Thread Ferruh Yigit
On 6/11/2016 7:34 AM, Thomas Monjalon wrote: > Hi Ferruh, > > 2016-06-10 19:32, Ferruh Yigit: >> --- a/mk/rte.app.mk >> +++ b/mk/rte.app.mk >> @@ -50,6 +50,14 @@ ifeq ($(NO_LDSCRIPT),) >> LDSCRIPT = $(RTE_LDSCRIPT) >> endif >> >> +ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y) >> +# Workaround to eal

[dpdk-dev] [PATCH v3 6/6] mk: prevent overlinking in applications

2016-06-11 Thread Thomas Monjalon
Hi Ferruh, 2016-06-10 19:32, Ferruh Yigit: > --- a/mk/rte.app.mk > +++ b/mk/rte.app.mk > @@ -50,6 +50,14 @@ ifeq ($(NO_LDSCRIPT),) > LDSCRIPT = $(RTE_LDSCRIPT) > endif > > +ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y) > +# Workaround to eal <-> mempool cyclic dependency > +_LDLIBS-$(CONFIG_RTE_LIBR

[dpdk-dev] [PATCH v3 6/6] mk: prevent overlinking in applications

2016-06-10 Thread Ferruh Yigit
Replace --no-as-needed linker flag with --as-needed flag, which will only link libraries directly called by application. It can be achieved now that the libraries dependencies are handled properly. Signed-off-by: Ferruh Yigit Signed-off-by: Thomas Monjalon --- mk/exec-env/linuxapp/rte.vars.mk |