Re: [dpdk-dev] [PATCH v3 5/9] pmdinfogen: move to drivers subdirectory

2017-06-21 Thread Thomas Monjalon
21/06/2017 13:39, Gaëtan Rivet: > On Wed, Jun 21, 2017 at 12:00:24PM +0200, Thomas Monjalon wrote: > > 21/06/2017 11:40, Gaëtan Rivet: > > > On Wed, Jun 21, 2017 at 09:57:18AM +0200, Thomas Monjalon wrote: > > > > Another (probably better) solution is to keep basic definitions > > > > and helpers i

Re: [dpdk-dev] [PATCH v3 5/9] pmdinfogen: move to drivers subdirectory

2017-06-21 Thread Gaëtan Rivet
On Wed, Jun 21, 2017 at 12:00:24PM +0200, Thomas Monjalon wrote: > 21/06/2017 11:40, Gaëtan Rivet: > > On Wed, Jun 21, 2017 at 09:57:18AM +0200, Thomas Monjalon wrote: > > > Another (probably better) solution is to keep basic definitions > > > and helpers in EAL: > > > - rte_pci.h keeps only some

Re: [dpdk-dev] [PATCH v3 5/9] pmdinfogen: move to drivers subdirectory

2017-06-21 Thread Thomas Monjalon
21/06/2017 11:40, Gaëtan Rivet: > On Wed, Jun 21, 2017 at 09:57:18AM +0200, Thomas Monjalon wrote: > > Another (probably better) solution is to keep basic definitions > > and helpers in EAL: > > - rte_pci.h keeps only some PCI definitions and helpers > > like rte_pci_addr and eal_parse_pci_BDF(

Re: [dpdk-dev] [PATCH v3 5/9] pmdinfogen: move to drivers subdirectory

2017-06-21 Thread Gaëtan Rivet
On Wed, Jun 21, 2017 at 09:57:18AM +0200, Thomas Monjalon wrote: > 21/06/2017 01:36, Gaetan Rivet: > > pmdinfogen has a dependency on the PCI bus. The latter must be built > > first. > > I think it should not be moved outside of buildtools. > Right, I agree. I took the simplest path here, but if

Re: [dpdk-dev] [PATCH v3 5/9] pmdinfogen: move to drivers subdirectory

2017-06-21 Thread Thomas Monjalon
21/06/2017 01:36, Gaetan Rivet: > pmdinfogen has a dependency on the PCI bus. The latter must be built > first. I think it should not be moved outside of buildtools. The build order can be fixed by installing headers before any compilation like proposed in this RFC: http://dpdk.org/patch/25463 A

[dpdk-dev] [PATCH v3 5/9] pmdinfogen: move to drivers subdirectory

2017-06-20 Thread Gaetan Rivet
pmdinfogen has a dependency on the PCI bus. The latter must be built first. Signed-off-by: Gaetan Rivet --- GNUmakefile| 2 +- MAINTAINERS| 2 +- buildtools/Makefile| 36 buildtools/pmdinfogen/Makefile | 47 - bui