Re: [dpdk-dev] [PATCH v3 4/4] app/testpmd: display/clear forwarding stats on demand

2019-03-21 Thread David Marchand
On Thu, Mar 21, 2019 at 7:50 PM Ferruh Yigit wrote: > On 3/20/2019 10:02 AM, David Marchand wrote: > > Add a new "show/clear fwd stats all" command to display fwd and port > > statistics on the fly. > > > > To be able to do so, the (testpmd only) rte_port structure can't be used > > to maintain a

Re: [dpdk-dev] [PATCH v3 4/4] app/testpmd: display/clear forwarding stats on demand

2019-03-21 Thread Ferruh Yigit
On 3/20/2019 10:02 AM, David Marchand wrote: > Add a new "show/clear fwd stats all" command to display fwd and port > statistics on the fly. > > To be able to do so, the (testpmd only) rte_port structure can't be used > to maintain any statistics. > Moved the stats dump parts from stop_packet_forw

Re: [dpdk-dev] [PATCH v3 4/4] app/testpmd: display/clear forwarding stats on demand

2019-03-20 Thread Ferruh Yigit
On 3/20/2019 12:44 PM, David Marchand wrote: > On Wed, Mar 20, 2019 at 1:25 PM Ferruh Yigit > wrote: > > On 3/20/2019 10:02 AM, David Marchand wrote: > > Add a new "show/clear fwd stats all" command to display fwd and port > > statistics on the fly. > >

Re: [dpdk-dev] [PATCH v3 4/4] app/testpmd: display/clear forwarding stats on demand

2019-03-20 Thread David Marchand
On Wed, Mar 20, 2019 at 1:25 PM Ferruh Yigit wrote: > On 3/20/2019 10:02 AM, David Marchand wrote: > > Add a new "show/clear fwd stats all" command to display fwd and port > > statistics on the fly. > > Won't this be duplicating existing commands: > "show port stats all|" > "clear port stats all|

Re: [dpdk-dev] [PATCH v3 4/4] app/testpmd: display/clear forwarding stats on demand

2019-03-20 Thread Ferruh Yigit
On 3/20/2019 10:02 AM, David Marchand wrote: > Add a new "show/clear fwd stats all" command to display fwd and port > statistics on the fly. Won't this be duplicating existing commands: "show port stats all|" "clear port stats all|" What benefit "show/clear fwd stats all" adds against existing on

[dpdk-dev] [PATCH v3 4/4] app/testpmd: display/clear forwarding stats on demand

2019-03-20 Thread David Marchand
Add a new "show/clear fwd stats all" command to display fwd and port statistics on the fly. To be able to do so, the (testpmd only) rte_port structure can't be used to maintain any statistics. Moved the stats dump parts from stop_packet_forwarding() and merge with fwd_port_stats_display() into fwd