Re: [dpdk-dev] [PATCH v3 35/37] doc: remove reference to make in tools guides

2020-09-04 Thread Pattan, Reshma
> -Original Message- > From: Bruce Richardson > > > > The ``dpdk-pdump`` tool depends on DPDK pcap PMD, so the system > > should have libpcap development files installed and the pcap PMD > > enabled in the build. > > > Sounds good, though I'd suggest changing "enabled" to "not disabl

Re: [dpdk-dev] [PATCH v3 35/37] doc: remove reference to make in tools guides

2020-09-04 Thread Bruce Richardson
On Fri, Sep 04, 2020 at 09:04:48AM +, Pattan, Reshma wrote: > > > > -Original Message- From: Power, Ciara > > > > diff --git a/doc/guides/tools/pdump.rst b/doc/guides/tools/pdump.rst > > index + * The ``dpdk-pdump`` tool depends on libpcap based PMD > > which must be +

Re: [dpdk-dev] [PATCH v3 35/37] doc: remove reference to make in tools guides

2020-09-04 Thread Pattan, Reshma
> -Original Message- > From: Power, Ciara > diff --git a/doc/guides/tools/pdump.rst b/doc/guides/tools/pdump.rst index > + * The ``dpdk-pdump`` tool depends on libpcap based PMD which must be > +installed on the board. > +Once the libpcap development files are ins

Re: [dpdk-dev] [PATCH v3 35/37] doc: remove reference to make in tools guides

2020-09-03 Thread Chautru, Nicolas
Hi Ciara, Fine with me for test-bbdev. (Ignore my parallel comment to point more explicitly to the build stage directory, that is already fine below). Acked-by: Nicolas Chautru > -Original Message- > From: Power, Ciara > Sent: Thursday, September 3, 2020 8:27 AM > To: dev@dpdk.org >

[dpdk-dev] [PATCH v3 35/37] doc: remove reference to make in tools guides

2020-09-03 Thread Ciara Power
Make is no longer supported for compiling DPDK, references are now removed in the documentation. Signed-off-by: Ciara Power Reviewed-by: Kevin Laatz --- doc/guides/tools/comp_perf.rst| 10 ++--- doc/guides/tools/cryptoperf.rst | 20 +++-- doc/guides/tools/pdump.rst