Re: [dpdk-dev] [PATCH v3 3/4] net/virtio: allocate fake mbuf in Rx queue

2021-03-15 Thread Maxime Coquelin
On 3/15/21 5:57 PM, David Marchand wrote: > On Mon, Mar 15, 2021 at 5:46 PM Maxime Coquelin > wrote: >> @@ -612,6 +622,8 @@ virtio_init_queue(struct rte_eth_dev *dev, uint16_t >> queue_idx) >> >> clean_vq: >> hw->cvq = NULL; >> + rte_free(fake_mbuf); >> +free_sw_ring: >>

Re: [dpdk-dev] [PATCH v3 3/4] net/virtio: allocate fake mbuf in Rx queue

2021-03-15 Thread David Marchand
On Mon, Mar 15, 2021 at 5:46 PM Maxime Coquelin wrote: > @@ -612,6 +622,8 @@ virtio_init_queue(struct rte_eth_dev *dev, uint16_t > queue_idx) > > clean_vq: > hw->cvq = NULL; > + rte_free(fake_mbuf); > +free_sw_ring: > rte_free(sw_ring); > free_hdr_mz: > rte_memzone

[dpdk-dev] [PATCH v3 3/4] net/virtio: allocate fake mbuf in Rx queue

2021-03-15 Thread Maxime Coquelin
While it is worth clarifying whether the fake mbuf in virtnet_rx struct is really necessary, it is sure that it heavily impacts cache usage by being part of the struct. Indeed, it uses two cachelines, and requires alignment on a cacheline. Before this series, it means it took 120 bytes in virtnet_