Re: [dpdk-dev] [PATCH v3 2/6] ethdev: add new attributes to hairpin config

2020-10-13 Thread Bing Zhao
@intel.com; > wenzhuo...@intel.com; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 2/6] ethdev: add new attributes to > hairpin config > > External email: Use caution opening links or attachments > > > 13/10/2020 14:29, Bing Zhao: > > From: Thomas Monjalon

Re: [dpdk-dev] [PATCH v3 2/6] ethdev: add new attributes to hairpin config

2020-10-13 Thread Thomas Monjalon
13/10/2020 14:29, Bing Zhao: > From: Thomas Monjalon > > 08/10/2020 14:05, Bing Zhao: > > > struct rte_eth_hairpin_conf { > > > - uint16_t peer_count; /**< The number of peers. */ > > > + uint32_t peer_count:16; /**< The number of peers. */ > > > > Why not keeping uint16_t? > > The insi

Re: [dpdk-dev] [PATCH v3 2/6] ethdev: add new attributes to hairpin config

2020-10-13 Thread Bing Zhao
beilei.x...@intel.com; > wenzhuo...@intel.com; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 2/6] ethdev: add new attributes to > hairpin config > > External email: Use caution opening links or attachments > > > 08/10/2020 14:05, Bing Zhao: > > struct rte_eth_hairpin_co

Re: [dpdk-dev] [PATCH v3 2/6] ethdev: add new attributes to hairpin config

2020-10-12 Thread Thomas Monjalon
08/10/2020 14:05, Bing Zhao: > struct rte_eth_hairpin_conf { > - uint16_t peer_count; /**< The number of peers. */ > + uint32_t peer_count:16; /**< The number of peers. */ Why not keeping uint16_t? > + uint32_t tx_explicit:1; /**< Explicit TX flow rule mode. */ > + uint32_t manua

[dpdk-dev] [PATCH v3 2/6] ethdev: add new attributes to hairpin config

2020-10-08 Thread Bing Zhao
To support two ports hairpin mode and keep the backward compatibility for the application, two new attribute members of hairpin queue configuration structure are added. `tx_explicit` means if the application itself will insert the TX part flow rules. If not set, PMD will insert the rules implicitl