[dpdk-dev] [PATCH v3 2/2] virtio: fix memory leak of virtqueue memzones

Hi Yuanhan, > -Original Message- > From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com] > Sent: Thursday, May 5, 2016 11:28 AM > To: Tan, Jianfeng > Cc: dev at dpdk.org; Xie, Huawei > Subject: Re: [dpdk-dev] [PATCH v3 2/2] virtio: fix memory leak of virtqueue &g

[dpdk-dev] [PATCH v3 2/2] virtio: fix memory leak of virtqueue memzones

ping... On Thu, Apr 28, 2016 at 10:33:08PM -0700, Yuanhan Liu wrote: > On Fri, Apr 29, 2016 at 12:48:46AM +, Jianfeng Tan wrote: > > @@ -447,6 +453,7 @@ int virtio_dev_queue_setup(struct rte_eth_dev *dev, > > > > hw->vtpci_ops->setup_queue(hw, vq); > > > > + vq->started = 1; > > Jud

[dpdk-dev] [PATCH v3 2/2] virtio: fix memory leak of virtqueue memzones

Issue: When virtio was proposed in DPDK, there is no API to free memzones. But this has changed since rte_memzone_free() has been implemented by commit ff909fe21f0a ("mem: introduce memzone freeing"). This patch is to make sure memzones in struct virtqueue, like mz and virtio_net_hdr_mz, are freed

[dpdk-dev] [PATCH v3 2/2] virtio: fix memory leak of virtqueue memzones

On Fri, Apr 29, 2016 at 12:48:46AM +, Jianfeng Tan wrote: > @@ -447,6 +453,7 @@ int virtio_dev_queue_setup(struct rte_eth_dev *dev, > > hw->vtpci_ops->setup_queue(hw, vq); > > + vq->started = 1; Judging that this is in the "_queue_setup" stage, and we have another stage called "_