[dpdk-dev] [PATCH v3 10/10] vmxnet3: remove excess inlining

On 3/5/15, 4:10 PM, "Stephen Hemminger" wrote: >From: Stephen Hemminger > >No reason to inline large functions. Compiler will decide already >based on optimization level. > >Also register array should be const. > >Signed-off-by: Stephen Hemminger One comment below. Acked-by: Yong Wang >---

[dpdk-dev] [PATCH v3 10/10] vmxnet3: remove excess inlining

On Fri, 6 Mar 2015 23:54:23 + Yong Wang wrote: > Since there is only one caller of this routine, inlining it should be > fine. But I have no problem with letting the compiler decide (which > probably will inline it anyway for this particular case). Sometimes compiler will not inline because

[dpdk-dev] [PATCH v3 10/10] vmxnet3: remove excess inlining

From: Stephen Hemminger No reason to inline large functions. Compiler will decide already based on optimization level. Also register array should be const. Signed-off-by: Stephen Hemminger --- lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(