Re: [dpdk-dev] [PATCH v3 1/3] examples/flow_classify: fix check of port and core

2021-04-29 Thread Min Hu (Connor)
在 2021/4/29 19:44, Thomas Monjalon 写道: Hi, 29/04/2021 11:37, Min Hu (Connor): Thanks Bernard . Hi, Thomas, Ferruh, any other comments? No need to ask for more comments after each ack. We are very busy and we'll come to this patch on time. You are sending a lot of fixes. That's very good b

Re: [dpdk-dev] [PATCH v3 1/3] examples/flow_classify: fix check of port and core

2021-04-29 Thread Thomas Monjalon
Hi, 29/04/2021 11:37, Min Hu (Connor): > Thanks Bernard . > > Hi, Thomas, Ferruh, any other comments? No need to ask for more comments after each ack. We are very busy and we'll come to this patch on time. You are sending a lot of fixes. That's very good but we need time to digest them :) Thanks

Re: [dpdk-dev] [PATCH v3 1/3] examples/flow_classify: fix check of port and core

2021-04-29 Thread Min Hu (Connor)
Thanks Bernard . Hi, Thomas, Ferruh, any other comments? 在 2021/4/29 17:07, Iremonger, Bernard 写道: -Original Message- From: Min Hu (Connor) Sent: Thursday, April 29, 2021 1:51 AM To: dev@dpdk.org Cc: Yigit, Ferruh ; Iremonger, Bernard ; tho...@monjalon.net Subject: [PATCH v3 1/3] examp

Re: [dpdk-dev] [PATCH v3 1/3] examples/flow_classify: fix check of port and core

2021-04-29 Thread Iremonger, Bernard
> -Original Message- > From: Min Hu (Connor) > Sent: Thursday, April 29, 2021 1:51 AM > To: dev@dpdk.org > Cc: Yigit, Ferruh ; Iremonger, Bernard > ; tho...@monjalon.net > Subject: [PATCH v3 1/3] examples/flow_classify: fix check of port and core > > According to the comments and logging,

[dpdk-dev] [PATCH v3 1/3] examples/flow_classify: fix check of port and core

2021-04-28 Thread Min Hu (Connor)
According to the comments and logging, the author just hope user to use the core and device which are in the same numa node for optimal performance. If not, A warning gives out. For example in flow_classify: ./build/flow_classify -a :7d:00.1 -l 93 Here: :7d:00.1 is on numa node 0. core 93