Re: [dpdk-dev] [PATCH v3 1/3] eal: add channel for multi-process communication

2018-01-25 Thread Ananyev, Konstantin
> > Previouly, there are three channels for multi-process > (i.e., primary/secondary) communication. > 1. Config-file based channel, in which, the primary process writes > info into a pre-defined config file, and the secondary process > reads the info out. > 2. vfio submodule has it

Re: [dpdk-dev] [PATCH v3 1/3] eal: add channel for multi-process communication

2018-01-25 Thread Thomas Monjalon
25/01/2018 12:27, Burakov, Anatoly: > Also, as a general note, i would prefer for sendmsg API's to return 0 on > success and -1 on failure, as number of sent messages is not only > meaningless to the user (since there's no way to tell if the value > returned is the value we expected), but also m

Re: [dpdk-dev] [PATCH v3 1/3] eal: add channel for multi-process communication

2018-01-25 Thread Burakov, Anatoly
Overall on this patch: Reviewed-by: Anatoly Burakov There are a few nitpicks below in comments. Also, as a general note, i would prefer for sendmsg API's to return 0 on success and -1 on failure, as number of sent messages is not only meaningless to the user (since there's no way to tell if

Re: [dpdk-dev] [PATCH v3 1/3] eal: add channel for multi-process communication

2018-01-25 Thread Thomas Monjalon
25/01/2018 05:16, Jianfeng Tan: > --- a/lib/librte_eal/rte_eal_version.map > +++ b/lib/librte_eal/rte_eal_version.map > + rte_eal_mp_action_register; > + rte_eal_mp_action_unregister; > + rte_eal_mp_sendmsg; Just a naming comment: I think you can drop "eal" in function names. "rte_mp_"

[dpdk-dev] [PATCH v3 1/3] eal: add channel for multi-process communication

2018-01-24 Thread Jianfeng Tan
Previouly, there are three channels for multi-process (i.e., primary/secondary) communication. 1. Config-file based channel, in which, the primary process writes info into a pre-defined config file, and the secondary process reads the info out. 2. vfio submodule has its own channel ba