Re: [dpdk-dev] [PATCH v3 1/2] telemetry: fix missing check for thread creation

2021-04-16 Thread Min Hu (Connor)
Hi, David, fixed in v4. Thanks. 在 2021/4/15 22:55, David Marchand 写道: On Thu, Apr 15, 2021 at 1:50 PM Min Hu (Connor) wrote: diff --git a/lib/librte_telemetry/telemetry.c b/lib/librte_telemetry/telemetry.c index 7e08afd..e6a99f3 100644 --- a/lib/librte_telemetry/telemetry.c +++ b/lib/librte_te

Re: [dpdk-dev] [PATCH v3 1/2] telemetry: fix missing check for thread creation

2021-04-16 Thread Min Hu (Connor)
Thanks Power, v4 has been sent, please check it out. 在 2021/4/16 0:11, Power, Ciara 写道: Hi Connor, Thanks for looking at this. Left some comments inline. Ciara -Original Message- From: Min Hu (Connor) Sent: Thursday 15 April 2021 12:50 To: dev@dpdk.org Cc: Yigit, Ferruh ; Power, Cia

Re: [dpdk-dev] [PATCH v3 1/2] telemetry: fix missing check for thread creation

2021-04-15 Thread Power, Ciara
Hi Connor, Thanks for looking at this. Left some comments inline. Ciara >-Original Message- >From: Min Hu (Connor) >Sent: Thursday 15 April 2021 12:50 >To: dev@dpdk.org >Cc: Yigit, Ferruh ; Power, Ciara >; Pattan, Reshma ; >david.march...@redhat.com >Subject: [PATCH v3 1/2] telemetry:

Re: [dpdk-dev] [PATCH v3 1/2] telemetry: fix missing check for thread creation

2021-04-15 Thread David Marchand
On Thu, Apr 15, 2021 at 1:50 PM Min Hu (Connor) wrote: > diff --git a/lib/librte_telemetry/telemetry.c > b/lib/librte_telemetry/telemetry.c > index 7e08afd..e6a99f3 100644 > --- a/lib/librte_telemetry/telemetry.c > +++ b/lib/librte_telemetry/telemetry.c > @@ -350,6 +350,7 @@ socket_listener(void

[dpdk-dev] [PATCH v3 1/2] telemetry: fix missing check for thread creation

2021-04-15 Thread Min Hu (Connor)
From: Chengwen Feng Add result check and message print out for thread creation after failure. Fixes: b80fe1805eee ("telemetry: introduce backward compatibility") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) --- lib/librte_telemetry/telemetry.c| 30 +