Re: [dpdk-dev] [PATCH v3 1/2] net/ice: factorize firmware loading

2021-07-05 Thread David Marchand
On Mon, Jul 5, 2021 at 3:18 PM Wang, Haiyue wrote: > > > -Original Message- > > From: dev On Behalf Of David Marchand > > Sent: Tuesday, June 29, 2021 16:07 > > To: dev@dpdk.org > > Cc: Yang, Qiming ; Zhang, Qi Z > > Subject: [dpdk-dev] [PATCH v3 1

Re: [dpdk-dev] [PATCH v3 1/2] net/ice: factorize firmware loading

2021-07-05 Thread Wang, Haiyue
> -Original Message- > From: dev On Behalf Of David Marchand > Sent: Tuesday, June 29, 2021 16:07 > To: dev@dpdk.org > Cc: Yang, Qiming ; Zhang, Qi Z > Subject: [dpdk-dev] [PATCH v3 1/2] net/ice: factorize firmware loading > > Both "normal" and &

Re: [dpdk-dev] [PATCH v3 1/2] net/ice: factorize firmware loading

2021-07-05 Thread Wang, Haiyue
> -Original Message- > From: Zhang, Qi Z > Sent: Monday, July 5, 2021 18:00 > To: David Marchand ; Wang, Haiyue > > Cc: dev@dpdk.org; Yang, Qiming > Subject: RE: [dpdk-dev] [PATCH v3 1/2] net/ice: factorize firmware loading > > > > > -O

Re: [dpdk-dev] [PATCH v3 1/2] net/ice: factorize firmware loading

2021-07-05 Thread Wang, Haiyue
> -Original Message- > From: David Marchand > Sent: Monday, July 5, 2021 16:34 > To: Wang, Haiyue > Cc: dev@dpdk.org; Yang, Qiming ; Zhang, Qi Z > > Subject: Re: [dpdk-dev] [PATCH v3 1/2] net/ice: factorize firmware loading > > On Mon, Jul 5, 2021 at 1

Re: [dpdk-dev] [PATCH v3 1/2] net/ice: factorize firmware loading

2021-07-05 Thread Zhang, Qi Z
> -Original Message- > From: David Marchand > Sent: Monday, July 5, 2021 4:34 PM > To: Wang, Haiyue > Cc: dev@dpdk.org; Yang, Qiming ; Zhang, Qi Z > > Subject: Re: [dpdk-dev] [PATCH v3 1/2] net/ice: factorize firmware loading > > On Mon, Jul 5, 2021 at 10:

Re: [dpdk-dev] [PATCH v3 1/2] net/ice: factorize firmware loading

2021-07-05 Thread David Marchand
On Mon, Jul 5, 2021 at 10:02 AM Wang, Haiyue wrote: > > > I'm wondering what's full name for ice firmware in F34, has any *.xz > > > postfix ? If so, the search method will also needs to be updated, since > > > we will check each file can be accessed: > > > > > > #define ICE_PKG_FILE_DEFAULT "/lib

Re: [dpdk-dev] [PATCH v3 1/2] net/ice: factorize firmware loading

2021-07-05 Thread Wang, Haiyue
> -Original Message- > From: David Marchand > Sent: Monday, July 5, 2021 15:08 > To: Wang, Haiyue > Cc: dev@dpdk.org; Yang, Qiming ; Zhang, Qi Z > > Subject: Re: [dpdk-dev] [PATCH v3 1/2] net/ice: factorize firmware loading > > On Mon, Jul 5, 2021 at

Re: [dpdk-dev] [PATCH v3 1/2] net/ice: factorize firmware loading

2021-07-05 Thread David Marchand
On Mon, Jul 5, 2021 at 3:43 AM Wang, Haiyue wrote: > > Hi David, > > > -Original Message- > > From: dev On Behalf Of David Marchand > > Sent: Tuesday, June 29, 2021 16:07 > > To: dev@dpdk.org > > Cc: Yang, Qiming ; Zhang, Qi Z > > Subject:

Re: [dpdk-dev] [PATCH v3 1/2] net/ice: factorize firmware loading

2021-07-04 Thread Wang, Haiyue
Hi David & Qi, > -Original Message- > From: Wang, Haiyue > Sent: Monday, July 5, 2021 09:43 > To: David Marchand ; dev@dpdk.org > Cc: Yang, Qiming ; Zhang, Qi Z > Subject: RE: [dpdk-dev] [PATCH v3 1/2] net/ice: factorize firmware loading > > Hi David,

Re: [dpdk-dev] [PATCH v3 1/2] net/ice: factorize firmware loading

2021-07-04 Thread Wang, Haiyue
Hi David, > -Original Message- > From: dev On Behalf Of David Marchand > Sent: Tuesday, June 29, 2021 16:07 > To: dev@dpdk.org > Cc: Yang, Qiming ; Zhang, Qi Z > Subject: [dpdk-dev] [PATCH v3 1/2] net/ice: factorize firmware loading > > Both "normal"

[dpdk-dev] [PATCH v3 1/2] net/ice: factorize firmware loading

2021-06-29 Thread David Marchand
Both "normal" and "dcf" inits have their copy of some firmware loading code. The DSN query is moved in specific parts for the "normal" and "dcf" init. A common helper ice_load_pkg is then introduced and takes an adapter pointer as its main input. This helper takes care of finding the right firmw