Re: [dpdk-dev] [PATCH v3 1/2] ethdev: add pre-defined meter policy API

2021-04-14 Thread Li Zhang
ko > ; Matan Azrad ; > lir...@marvell.com; Wisam Monther ; Li, Xiaoyun > ; Singh, Jasvinder ; Yigit, > Ferruh ; Andrew Rybchenko > ; Ray Kinsella ; Jerin > Jacob ; Hemant Agrawal > ; dev@dpdk.org; Raslan Darawsheh > ; Roni Bar Yanai ; Haifei Luo > ; Jiawei(Jonny) Wang &g

Re: [dpdk-dev] [PATCH v3 1/2] ethdev: add pre-defined meter policy API

2021-04-14 Thread Dumitrescu, Cristian
> >14/04/2021 06:55, Li Zhang: > >> > > + * Example #2: GREEN - Do nothing, YELLOW - Do nothing, RED - > DROP > >> > > + * struct rte_mtr_meter_policy_params policy_1 = > >> > > + * (struct > >> > > rte_mtr_meter_policy_params) { > >> > > + * .actions[R

Re: [dpdk-dev] [PATCH v3 1/2] ethdev: add pre-defined meter policy API

2021-04-14 Thread Thomas Monjalon
14/04/2021 10:47, Asaf Penso: > From: Thomas Monjalon > >Cristian, Li, please remove useless context when replying. > > > >14/04/2021 06:55, Li Zhang: > >> > > + * Example #2: GREEN - Do nothing, YELLOW - Do nothing, RED - DROP > >> > > + * struct rte_mtr_meter_policy_params policy_1 = > >> > > +

Re: [dpdk-dev] [PATCH v3 1/2] ethdev: add pre-defined meter policy API

2021-04-14 Thread Li Zhang
Cc: Ori Kam ; Slava Ovsiienko > >; Matan Azrad ; > >lir...@marvell.com; Wisam Monther ; Li, Xiaoyun > >; Singh, Jasvinder ; > >Yigit, Ferruh ; Andrew Rybchenko > >; Ray Kinsella ; Jerin > >Jacob ; Hemant Agrawal > ; > >dev@dpdk.org; Raslan Darawsheh ; Roni B

Re: [dpdk-dev] [PATCH v3 1/2] ethdev: add pre-defined meter policy API

2021-04-14 Thread Asaf Penso
gt;; Yigit, Ferruh ; Andrew >Rybchenko ; Ray Kinsella >; Jerin Jacob ; Hemant Agrawal >; dev@dpdk.org; Raslan Darawsheh >; Roni Bar Yanai ; Haifei Luo >; Jiawei(Jonny) Wang >Subject: Re: [dpdk-dev] [PATCH v3 1/2] ethdev: add pre-defined meter policy >API > >Cristian, Li, please

Re: [dpdk-dev] [PATCH v3 1/2] ethdev: add pre-defined meter policy API

2021-04-14 Thread Matan Azrad
From: Thomas Monjalon > Cristian, Li, please remove useless context when replying. > > 14/04/2021 06:55, Li Zhang: > > > > + * Example #2: GREEN - Do nothing, YELLOW - Do nothing, RED - DROP > > > > + * struct rte_mtr_meter_policy_params policy_1 = > > > > + *

Re: [dpdk-dev] [PATCH v3 1/2] ethdev: add pre-defined meter policy API

2021-04-14 Thread Thomas Monjalon
Cristian, Li, please remove useless context when replying. 14/04/2021 06:55, Li Zhang: > > > + * Example #2: GREEN - Do nothing, YELLOW - Do nothing, RED - DROP > > > + * struct rte_mtr_meter_policy_params policy_1 = > > > + * (struct > > > rte_mtr_meter_policy_

Re: [dpdk-dev] [PATCH v3 1/2] ethdev: add pre-defined meter policy API

2021-04-13 Thread Li Zhang
Hi Cristian, This patch is depend on series=16351. Depends-on: series=16351 ("Add ASO meter support in MLX5 PMD ") https://patchwork.dpdk.org/project/dpdk/list/?series=16351 Because RTE API change and it need change PMD part to fix building issue. Regards, Li Zhang > -Original Message-

Re: [dpdk-dev] [PATCH v3 1/2] ethdev: add pre-defined meter policy API

2021-04-13 Thread Kinsella, Ray
On 13/04/2021 01:14, Li Zhang wrote: > Currently, the flow meter policy does not support multiple actions > per color; also the allowed action types per color are very limited. > In addition, the policy cannot be pre-defined. > > Due to the growing in flow actions offload abilities there is a p

Re: [dpdk-dev] [PATCH v3 1/2] ethdev: add pre-defined meter policy API

2021-04-13 Thread Dumitrescu, Cristian
Hi Li, Here are some initial comments while waiting for a new version that applies cleanly. > -Original Message- > From: Li Zhang > Sent: Tuesday, April 13, 2021 1:14 AM > To: dek...@nvidia.com; or...@nvidia.com; viachesl...@nvidia.com; > ma...@nvidia.com; shah...@nvidia.com; Dumitrescu

Re: [dpdk-dev] [PATCH v3 1/2] ethdev: add pre-defined meter policy API

2021-04-13 Thread Dumitrescu, Cristian
Hi Li, This patch does not apply on top of the latest DPDK. Can you please rebase on top of DPDK version and resend. If this depends on some other patch sets to be applied first, then please send clear steps on how to apply. Thanks, Cristian

[dpdk-dev] [PATCH v3 1/2] ethdev: add pre-defined meter policy API

2021-04-12 Thread Li Zhang
Currently, the flow meter policy does not support multiple actions per color; also the allowed action types per color are very limited. In addition, the policy cannot be pre-defined. Due to the growing in flow actions offload abilities there is a potential for the user to use variety of actions pe