[dpdk-dev] [PATCH v3 08/13] testpmd: rework csum forward engine

> -Original Message- > From: Ananyev, Konstantin > Sent: Thursday, November 27, 2014 12:35 AM > To: Olivier MATZ; dev at dpdk.org > Cc: Walukiewicz, Miroslaw; Liu, Jijiang; Liu, Yong; jigsaw at gmail.com; > Richardson, > Bruce > Subject: RE: [PATCH v3 08/13] testpmd: rework csum forward

[dpdk-dev] [PATCH v3 08/13] testpmd: rework csum forward engine

Hi Oliver, > -Original Message- > From: Olivier MATZ [mailto:olivier.matz at 6wind.com] > Sent: Wednesday, November 26, 2014 2:55 PM > To: Ananyev, Konstantin; dev at dpdk.org > Cc: Walukiewicz, Miroslaw; Liu, Jijiang; Liu, Yong; jigsaw at gmail.com; > Richardson, Bruce > Subject: Re: [PA

[dpdk-dev] [PATCH v3 08/13] testpmd: rework csum forward engine

Hi Konstantin, On 11/26/2014 01:25 PM, Ananyev, Konstantin wrote: >> By the way (this is probably off-topic), but I'm wondering if the TX >> flags should have the same values than the RX flags: >> >> #define PKT_TX_IPV4 PKT_RX_IPV4_HDR >> #define PKT_TX_IPV6 PKT_RX_IPV6_H

[dpdk-dev] [PATCH v3 08/13] testpmd: rework csum forward engine

> -Original Message- > From: Olivier MATZ [mailto:olivier.matz at 6wind.com] > Sent: Wednesday, November 26, 2014 7:15 PM > To: Ananyev, Konstantin; dev at dpdk.org > Cc: Walukiewicz, Miroslaw; Liu, Jijiang; Liu, Yong; jigsaw at gmail.com; > Richardson, > Bruce > Subject: Re: [PATCH v3 0

[dpdk-dev] [PATCH v3 08/13] testpmd: rework csum forward engine

> -Original Message- > From: Olivier MATZ [mailto:olivier.matz at 6wind.com] > Sent: Wednesday, November 26, 2014 11:15 AM > To: Ananyev, Konstantin; dev at dpdk.org > Cc: Walukiewicz, Miroslaw; Liu, Jijiang; Liu, Yong; jigsaw at gmail.com; > Richardson, Bruce > Subject: Re: [PATCH v3 08

[dpdk-dev] [PATCH v3 08/13] testpmd: rework csum forward engine

Hi Konstantin, On 11/26/2014 11:10 AM, Ananyev, Konstantin wrote: > As I can see you removed code that sets up TX_PKT_IPV4 and TX_PKT_IPV6 of > ol_flags. > I think that we need to keep it. > The reason for that is: > With FVL, to make HW TX checksum offload work, SW is responsible to provide >

[dpdk-dev] [PATCH v3 08/13] testpmd: rework csum forward engine

Hi Oliver, > -Original Message- > From: Olivier Matz [mailto:olivier.matz at 6wind.com] > Sent: Thursday, November 20, 2014 10:59 PM > To: dev at dpdk.org > Cc: olivier.matz at 6wind.com; Walukiewicz, Miroslaw; Liu, Jijiang; Liu, > Yong; jigsaw at gmail.com; Richardson, Bruce; Ananyev, Ko

[dpdk-dev] [PATCH v3 08/13] testpmd: rework csum forward engine

The csum forward engine was becoming too complex to be used and extended (the next commits want to add the support of TSO): - no explaination about what the code does - code is not factorized, lots of code duplicated, especially between ipv4/ipv6 - user command line api: use of bitmasks that nee